public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Carl Love <carll@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] PowerPC: bp-permanent.exp, kill-after-signal fix Date: Wed, 18 May 2022 15:12:19 +0000 (GMT) [thread overview] Message-ID: <20220518151219.08029383940B@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=301fe55e9c44d03ebdfbd2b34c9b8570cc2f9f18 commit 301fe55e9c44d03ebdfbd2b34c9b8570cc2f9f18 Author: Carl Love <cel@us.ibm.com> Date: Fri May 6 21:49:22 2022 +0000 PowerPC: bp-permanent.exp, kill-after-signal fix Fix changes that didn't make it into commit: dd9cd55e990bcc9f8448cac38d242d53974b3604. Fix missing -wrap on gdb_test_multiple in gdb.base/kill-after-signal.exp that is causing regression test on x86_64-linux with taskset -c 0. Diff: --- gdb/testsuite/gdb.base/bp-permanent.exp | 15 +++++++++------ gdb/testsuite/gdb.base/kill-after-signal.exp | 15 +++++++++------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/gdb/testsuite/gdb.base/bp-permanent.exp b/gdb/testsuite/gdb.base/bp-permanent.exp index 21b0bc7bb2d..1ad9a698db8 100644 --- a/gdb/testsuite/gdb.base/bp-permanent.exp +++ b/gdb/testsuite/gdb.base/bp-permanent.exp @@ -260,28 +260,31 @@ proc test {always_inserted sw_watchpoint} { -re "Program received signal SIGTRAP.*$gdb_prompt $" { fail $test } - -re ".*signal handler called.*$gdb_prompt $" { - # PowerPC Linux kernel patchs: + -re "signal handler called.*$gdb_prompt $" { + # After PowerPC Linux kernel commit: + # # commit: 0138ba5783ae0dcc799ad401a1e8ac8333790df9 # powerpc/64/signal: Balance return predictor # stack in signal trampoline. # # The kernel places an additional brctl instruction - # in the vdso to call the user hadler. + # in the vdso to call the user handler. + # + # And then this commit: # # commit 24321ac668e452a4942598533d267805f291fdc9 # powerpc/64/signal: Fix regression in # __kernel_sigtramp_rt64() semantics # - # Updates the semantics of __kernel_sigtramp_rt64(). - # It adds a new symbol to serve as a jump target from + # updates the semantics of __kernel_sigtramp_rt64(). + # It added a new symbol to serve as a jump target from # the kernel to the trampoline. # # The net result of these changes is that gdb stops # at __kernel_start_sigtramp_rt64. Need to do one # more stepi to reach the expected location in the user # signal handler. - gdb_test "p \$pc" ".*__kernel_start_sigtramp_rt64.*" \ + gdb_test "p \$pc" "__kernel_start_sigtramp_rt64.*" \ "in kernel code" gdb_test "stepi" "handler .*" $test } diff --git a/gdb/testsuite/gdb.base/kill-after-signal.exp b/gdb/testsuite/gdb.base/kill-after-signal.exp index 7450b2ae4b9..bdb2a159bfa 100644 --- a/gdb/testsuite/gdb.base/kill-after-signal.exp +++ b/gdb/testsuite/gdb.base/kill-after-signal.exp @@ -39,24 +39,27 @@ gdb_test "continue" "Program received signal SIGUSR1, .*" set test "handler" gdb_test_multiple "stepi" $test { - -re "\r\nhandler .*" { + -re -wrap "\r\nhandler .*" { pass $test } - -re ".*signal handler called.*$gdb_prompt $" { - # PowerPC Linux kernel patchs: + -re "signal handler called.*$gdb_prompt $" { + # After PowerPC Linux kernel commit: + # # commit: 0138ba5783ae0dcc799ad401a1e8ac8333790df9 # powerpc/64/signal: Balance return predictor # stack in signal trampoline. # # The kernel places an additional brctl instruction - # in the vdso to call the user hadler. + # in the vdso to call the user handler. + # + # And then this commit: # # commit 24321ac668e452a4942598533d267805f291fdc9 # powerpc/64/signal: Fix regression in # __kernel_sigtramp_rt64() semantics # - # Updates the semantics of __kernel_sigtramp_rt64(). - # It adds a new symbol to serve as a jump target from + # updates the semantics of __kernel_sigtramp_rt64(). + # It added a new symbol to serve as a jump target from # the kernel to the trampoline. # # The net result of these changes is that gdb stops
next reply other threads:[~2022-05-18 15:12 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 15:12 Carl Love [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-05-06 17:46 Carl Love
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220518151219.08029383940B@sourceware.org \ --to=carll@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).