public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Pedro Alves <palves@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Make structs breakpoint/base_breakpoint/catchpoint be abstract Date: Fri, 20 May 2022 19:42:33 +0000 (GMT) [thread overview] Message-ID: <20220520194233.7EA6F3830890@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb commit 1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb Author: Pedro Alves <pedro@palves.net> Date: Fri May 6 20:09:04 2022 +0100 Make structs breakpoint/base_breakpoint/catchpoint be abstract You should never instanciate these types directly. Change-Id: I8086c74c415eadbd44924bb0ef20f34b5b97ee6f Diff: --- gdb/breakpoint.c | 15 +++++++++++++++ gdb/breakpoint.h | 6 +++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 385c92a6e7b..8f6794511e7 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -252,6 +252,21 @@ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = create_breakpoints_sal, }; +/* Implementation of abstract dtors. These must exist to satisfy the + linker. */ + +breakpoint::~breakpoint () +{ +} + +base_breakpoint::~base_breakpoint () +{ +} + +catchpoint::~catchpoint () +{ +} + /* The structure to be used in regular breakpoints. */ struct ordinary_breakpoint : public base_breakpoint { diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index fb8651c55c3..b7e3b4dc6a1 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -631,7 +631,7 @@ struct breakpoint DISABLE_COPY_AND_ASSIGN (breakpoint); - virtual ~breakpoint () = default; + virtual ~breakpoint () = 0; /* Allocate a location for this breakpoint. */ virtual struct bp_location *allocate_location (); @@ -862,6 +862,8 @@ struct base_breakpoint : public breakpoint { using breakpoint::breakpoint; + ~base_breakpoint () override = 0; + void re_set () override; int insert_location (struct bp_location *) override; int remove_location (struct bp_location *, @@ -1023,6 +1025,8 @@ struct catchpoint : public base_breakpoint COND_STRING is not NULL, then store it in the breakpoint. */ catchpoint (struct gdbarch *gdbarch, bool temp, const char *cond_string); + ~catchpoint () override = 0; + void re_set () override { /* For catchpoints, the default is to do nothing. */
reply other threads:[~2022-05-20 19:42 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220520194233.7EA6F3830890@sourceware.org \ --to=palves@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).