public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Pedro Alves <palves@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] ranged_breakpoint: move initialization to ctor Date: Fri, 20 May 2022 19:42:48 +0000 (GMT) [thread overview] Message-ID: <20220520194248.AF5693830881@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b925bf21e073f0d9531385e8cfc3a825887c0778 commit b925bf21e073f0d9531385e8cfc3a825887c0778 Author: Pedro Alves <pedro@palves.net> Date: Fri May 6 22:48:11 2022 +0100 ranged_breakpoint: move initialization to ctor Move initialization of ranged_breakpoint's fields to its ctor. Change-Id: If7b842861f3cc6a429ea329d45598b5852283ba3 Diff: --- gdb/breakpoint.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index ced976ca39d..1c1dbfb3ad7 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -317,9 +317,20 @@ struct dprintf_breakpoint : public ordinary_breakpoint /* Ranged breakpoints. */ struct ranged_breakpoint : public ordinary_breakpoint { - explicit ranged_breakpoint (struct gdbarch *gdbarch) + explicit ranged_breakpoint (struct gdbarch *gdbarch, + const symtab_and_line &sal_start, + int length, + event_location_up start_location, + event_location_up end_location) : ordinary_breakpoint (gdbarch, bp_hardware_breakpoint) { + bp_location *bl = add_location (sal_start); + bl->length = length; + + disposition = disp_donttouch; + + location = std::move (start_location); + location_range_end = std::move (end_location); } int breakpoint_hit (const struct bp_location *bl, @@ -9436,13 +9447,13 @@ break_range_command (const char *arg, int from_tty) return; } - /* Now set up the breakpoint. */ - std::unique_ptr<breakpoint> br (new ranged_breakpoint (get_current_arch ())); - br->add_location (sal_start); - br->disposition = disp_donttouch; - br->location = std::move (start_location); - br->location_range_end = std::move (end_location); - br->loc->length = length; + /* Now set up the breakpoint and install it. */ + + std::unique_ptr<breakpoint> br + (new ranged_breakpoint (get_current_arch (), + sal_start, length, + std::move (start_location), + std::move (end_location))); install_breakpoint (false, std::move (br), true); }
reply other threads:[~2022-05-20 19:42 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220520194248.AF5693830881@sourceware.org \ --to=palves@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).