public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: fix gdb.trace/signal.exp on x86
Date: Mon, 30 May 2022 16:59:46 +0000 (GMT)	[thread overview]
Message-ID: <20220530165946.CAB993857025@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=da18821a9a2a36e0dc963d70252fc895906c264c

commit da18821a9a2a36e0dc963d70252fc895906c264c
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Mon May 30 12:54:47 2022 -0400

    gdb/testsuite: fix gdb.trace/signal.exp on x86
    
    Patch
    
      202be274a41a ("opcodes/i386: remove trailing whitespace from insns with zero operands")
    
    causes this regression:
    
      FAIL: gdb.trace/signal.exp: find syscall insn in kill
    
    It's because the test still expects to match a whitespace after the
    instruction, which the patch mentioned above removed.  Remove the
    whitespaces for the regexp.
    
    Change-Id: Ie194273cc942bfd91332d4035f6eec55b7d3a428

Diff:
---
 gdb/testsuite/gdb.trace/signal.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp
index e5b60897486..782abeb69d3 100644
--- a/gdb/testsuite/gdb.trace/signal.exp
+++ b/gdb/testsuite/gdb.trace/signal.exp
@@ -55,7 +55,7 @@ set syscall_insn ""
 # Define the syscall instruction for each target.
 
 if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } {
-    set syscall_insn "\[ \t\](int|syscall|sysenter)\[ \t\]"
+    set syscall_insn "\[ \t\](int|syscall|sysenter)"
 } elseif { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] } {
     set syscall_insn "\[ \t\](swi|svc)\[ \t\]"
 } else {


                 reply	other threads:[~2022-05-30 16:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220530165946.CAB993857025@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).