public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: resolve duplicate test name in gdb.trace/signal.exp
Date: Tue, 31 May 2022 08:26:13 +0000 (GMT)	[thread overview]
Message-ID: <20220531082613.5BB5A383E81E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=42745ac5821471e8b953d24730c82c3cefa72d67

commit 42745ac5821471e8b953d24730c82c3cefa72d67
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Tue May 31 09:21:20 2022 +0100

    gdb/testsuite: resolve duplicate test name in gdb.trace/signal.exp
    
    Spotted a duplicate test name in gdb.trace/signal.exp, resolved in
    this commit by making use of 'with_test_prefix'.

Diff:
---
 gdb/testsuite/gdb.trace/signal.exp | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp
index 782abeb69d3..da9f0603a5b 100644
--- a/gdb/testsuite/gdb.trace/signal.exp
+++ b/gdb/testsuite/gdb.trace/signal.exp
@@ -125,7 +125,9 @@ delete_breakpoints
 gdb_breakpoint "start" qualified
 gdb_continue_to_breakpoint "continue to start"
 
-gdb_assert { 0 == [get_integer_valueof "counter" "1"] } "counter is zero"
+with_test_prefix "counter is zero" {
+    gdb_assert { 0 == [get_integer_valueof "counter" "1"] } "assert check"
+}
 
 delete_breakpoints
 
@@ -147,8 +149,10 @@ gdb_test_no_output "tstop"
 
 set iterations [get_integer_valueof "iterations" "0"]
 
-gdb_assert { $iterations == [get_integer_valueof "counter" "0"] } \
-    "iterations equals to counter"
+with_test_prefix "iterations equals to counter" {
+    gdb_assert { $iterations == [get_integer_valueof "counter" "0"] } \
+	"assert check"
+}
 
 # Record the hit times of each tracepoint in this array.
 array set tracepoint_hits { }


                 reply	other threads:[~2022-05-31  8:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220531082613.5BB5A383E81E@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).