public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Nils-Christian Kempke <nckempke@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] testsuite, fortran: add required external keyword
Date: Tue, 31 May 2022 14:45:48 +0000 (GMT)	[thread overview]
Message-ID: <20220531144548.DE50F395A060@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=93bbd6c793f028afde22d6a6ad52edd812be8160

commit 93bbd6c793f028afde22d6a6ad52edd812be8160
Author: Nils-Christian Kempke <nils-christian.kempke@intel.com>
Date:   Tue May 31 16:43:44 2022 +0200

    testsuite, fortran: add required external keyword
    
    Currenlty, ifx/ifort cannot compile the given executable as it is not
    valid Fortran.  It is missing the external keyword on the
    no_arg_subroutine.  Gfortran compiles the example but this is actually
    a bug and there is an open gcc ticket for this here:
    
       https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50377
    
    Adding the keyword does not change the gfortran compiling of the example.
    It will, however, prevent a future fail once 50377 has been addressed.

Diff:
---
 gdb/testsuite/gdb.fortran/function-calls.f90 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/testsuite/gdb.fortran/function-calls.f90 b/gdb/testsuite/gdb.fortran/function-calls.f90
index b56c5c97f7b..e9c8c44afd1 100644
--- a/gdb/testsuite/gdb.fortran/function-calls.f90
+++ b/gdb/testsuite/gdb.fortran/function-calls.f90
@@ -198,6 +198,7 @@ program function_calls
     type(cart_nd) :: c_nd
     type(nested_cart_3d) :: nested_c
     character(40) :: returned_string, returned_string_debugger
+    external no_arg_subroutine
     real8 = 3.00
     real4 = 9.3
     integer_array = 17


                 reply	other threads:[~2022-05-31 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220531144548.DE50F395A060@sourceware.org \
    --to=nckempke@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).