public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Luis Machado <luisgpm@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [arm] d0..d15 are 64-bit each, not 32-bit Date: Wed, 1 Jun 2022 10:24:58 +0000 (GMT) [thread overview] Message-ID: <20220601102458.E1C4F3834E6C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=39fc7ff66b30f1581d4a1a97e6857b6bfcccf860 commit 39fc7ff66b30f1581d4a1a97e6857b6bfcccf860 Author: Yvan Roux <yvan.roux@foss.st.com> Date: Wed Jun 1 11:08:00 2022 +0000 [arm] d0..d15 are 64-bit each, not 32-bit When unwinding the stack, the floating point registers d0 to d15 need to be handled as double words, not words. Only the first 8 registers have been confirmed fixed with this patch on a STM32F407-DISC0 board, but the upper 8 registers on Cortex-M33 should be handled in the same way. The test consisted of running a program compiled with float-abi=hard. In the main function, a function taking a double as an argument was called. After the function call, a hardware timer was used to trigger an interrupt. In the debug session, a breakpoint was set in the function called from main to verify the content of the registers using "info float" and another breakpoint in the interrupt handler was used to check the same registers using "info float" on frame 2 (the frame just before the dummy frame created for the signal handler in gdb). Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com> Signed-off-by: Yvan Roux <yvan.roux@foss.st.com> Diff: --- gdb/arm-tdep.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 5ea66898747..d35c49bc1ea 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -3464,10 +3464,10 @@ arm_m_exception_cache (struct frame_info *this_frame) /* Extended stack frame type used. */ fpu_regs_stack_offset = unwound_sp + sp_r0_offset + 0x20; - for (i = 0; i < 16; i++) + for (i = 0; i < 8; i++) { cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); - fpu_regs_stack_offset += 4; + fpu_regs_stack_offset += 8; } cache->saved_regs[ARM_FPSCR_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x60); fpu_regs_stack_offset += 4; @@ -3476,10 +3476,10 @@ arm_m_exception_cache (struct frame_info *this_frame) { /* Handle floating-point callee saved registers. */ fpu_regs_stack_offset = 0x90; - for (i = 16; i < 32; i++) + for (i = 8; i < 16; i++) { cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); - fpu_regs_stack_offset += 4; + fpu_regs_stack_offset += 8; } arm_cache_set_active_sp_value (cache, tdep, unwound_sp + sp_r0_offset + 0xD0);
reply other threads:[~2022-06-01 10:24 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220601102458.E1C4F3834E6C@sourceware.org \ --to=luisgpm@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).