public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove obsolete Python 2 comment
@ 2022-06-05 16:14 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-06-05 16:14 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ca9aae53bd5bf4d24f4c9ea6f4dc1606eb9cfc3c
commit ca9aae53bd5bf4d24f4c9ea6f4dc1606eb9cfc3c
Author: Tom Tromey <tom@tromey.com>
Date: Sun Jun 5 10:09:42 2022 -0600
Remove obsolete Python 2 comment
I found a comment that referred to Python 2, but that is now obsolete
-- the code it refers to is gone. I'm checking in this patch to
remove the comment.
There's a similar comment elsewhere, but I plan to remove that one in
another patch I'm going to submit shortly.
Diff:
---
gdb/python/py-value.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c
index e779f491b5b..0f7003363cc 100644
--- a/gdb/python/py-value.c
+++ b/gdb/python/py-value.c
@@ -1840,13 +1840,6 @@ convert_value_from_python (PyObject *obj)
if (cmp >= 0)
value = value_from_longest (builtin_type_pybool, cmp);
}
- /* Make a long logic check first. In Python 3.x, internally,
- all integers are represented as longs. In Python 2.x, there
- is still a differentiation internally between a PyInt and a
- PyLong. Explicitly do this long check conversion first. In
- GDB, for Python 3.x, we #ifdef PyInt = PyLong. This check has
- to be done first to ensure we do not lose information in the
- conversion process. */
else if (PyLong_Check (obj))
{
LONGEST l = PyLong_AsLongLong (obj);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-05 16:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-05 16:14 [binutils-gdb] Remove obsolete Python 2 comment Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).