From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id EB67B383665B; Sun, 5 Jun 2022 16:14:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB67B383665B Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove obsolete Python 2 comment X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: c8eab1d7c92ad72089c98e5753ebc96419e3674a X-Git-Newrev: ca9aae53bd5bf4d24f4c9ea6f4dc1606eb9cfc3c Message-Id: <20220605161438.EB67B383665B@sourceware.org> Date: Sun, 5 Jun 2022 16:14:38 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jun 2022 16:14:39 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dca9aae53bd5b= f4d24f4c9ea6f4dc1606eb9cfc3c commit ca9aae53bd5bf4d24f4c9ea6f4dc1606eb9cfc3c Author: Tom Tromey Date: Sun Jun 5 10:09:42 2022 -0600 Remove obsolete Python 2 comment =20 I found a comment that referred to Python 2, but that is now obsolete -- the code it refers to is gone. I'm checking in this patch to remove the comment. =20 There's a similar comment elsewhere, but I plan to remove that one in another patch I'm going to submit shortly. Diff: --- gdb/python/py-value.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c index e779f491b5b..0f7003363cc 100644 --- a/gdb/python/py-value.c +++ b/gdb/python/py-value.c @@ -1840,13 +1840,6 @@ convert_value_from_python (PyObject *obj) if (cmp >=3D 0) value =3D value_from_longest (builtin_type_pybool, cmp); } - /* Make a long logic check first. In Python 3.x, internally, - all integers are represented as longs. In Python 2.x, there - is still a differentiation internally between a PyInt and a - PyLong. Explicitly do this long check conversion first. In - GDB, for Python 3.x, we #ifdef PyInt =3D PyLong. This check has - to be done first to ensure we do not lose information in the - conversion process. */ else if (PyLong_Check (obj)) { LONGEST l =3D PyLong_AsLongLong (obj);