From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 3A3823841446; Mon, 6 Jun 2022 17:27:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A3823841446 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb] Enable some more print_one_insn selftests X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: faec7017f0302e33a3d2be107e83a3ef21a4813e X-Git-Newrev: 4ab19f4c9b3c838cd904a501b77148a459420b4c Message-Id: <20220606172757.3A3823841446@sourceware.org> Date: Mon, 6 Jun 2022 17:27:57 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 17:27:57 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D4ab19f4c9b3c= 838cd904a501b77148a459420b4c commit 4ab19f4c9b3c838cd904a501b77148a459420b4c Author: Tom de Vries Date: Mon Jun 6 19:27:46 2022 +0200 [gdb] Enable some more print_one_insn selftests =20 In print_one_insn_test we have this cluster of skipped tests: ... case bfd_arch_ia64: case bfd_arch_mep: case bfd_arch_mips: case bfd_arch_tic6x: case bfd_arch_xtensa: return; ... =20 Enable some of these, and document in more detail why they're enabled or skipped. =20 Likewise, document bfd_arch_or1k because it's an odd case. =20 Tested on x86_64-linux. Diff: --- gdb/disasm-selftests.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/gdb/disasm-selftests.c b/gdb/disasm-selftests.c index 266745d01c7..4f5667bc4e2 100644 --- a/gdb/disasm-selftests.c +++ b/gdb/disasm-selftests.c @@ -50,11 +50,29 @@ print_one_insn_test (struct gdbarch *gdbarch) len =3D sizeof (arm_insn); break; case bfd_arch_ia64: + /* We get: + internal-error: gdbarch_sw_breakpoint_from_kind: + Assertion `gdbarch->sw_breakpoint_from_kind !=3D NULL' failed. */ + return; case bfd_arch_mep: + /* Disassembles as '*unknown*' insn, then len self-check fails. */ + return; case bfd_arch_mips: + if (gdbarch_bfd_arch_info (gdbarch)->mach =3D=3D bfd_mach_mips16) + /* Disassembles insn, but len self-check fails. */ + return; + goto generic_case; case bfd_arch_tic6x: + /* Disassembles as '' insn, but len + self-check passes, so let's allow it. */ + goto generic_case; case bfd_arch_xtensa: + /* Disassembles insn, but len self-check fails. */ return; + case bfd_arch_or1k: + /* Disassembles as '*unknown*' insn, but len self-check passes, so l= et's + allow it. */ + goto generic_case; case bfd_arch_s390: /* nopr %r7 */ static const gdb_byte s390_insn[] =3D {0x07, 0x07};