From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 6241338308B9; Mon, 6 Jun 2022 18:48:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6241338308B9 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove "-break-insert -r" tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 38015f6710d67d700f34cfecc6d9fe5ae6241252 X-Git-Newrev: c2ebdf6a7def7cc4fda0b965554d259177b2fe26 Message-Id: <20220606184803.6241338308B9@sourceware.org> Date: Mon, 6 Jun 2022 18:48:03 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 18:48:03 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc2ebdf6a7def= 7cc4fda0b965554d259177b2fe26 commit c2ebdf6a7def7cc4fda0b965554d259177b2fe26 Author: Tom Tromey Date: Thu May 26 10:17:02 2022 -0600 Remove "-break-insert -r" tests =20 PR mi/14270 points out that mi-break.exp has some tests for an unimplemented "-r" switch for "-break-insert". This switch was never implemented, and is not documented -- though it is mentioned in a comment in the documentation. This patch removes the test and the doc comment. =20 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D14270 Diff: --- gdb/doc/gdb.texinfo | 6 ---- gdb/testsuite/gdb.mi/mi-break.exp | 70 -----------------------------------= ---- 2 files changed, 76 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 434add3a663..3a8cf3f1b6b 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -31431,12 +31431,6 @@ addr=3D"0x00010774",func=3D"foo",file=3D"recursive= 2.c", fullname=3D"/home/foo/recursive2.c",line=3D"11",thread-groups=3D["i1"], times=3D"0"@}]@} (gdb) -@c -break-insert -r foo.* -@c ~int foo(int, int); -@c ^done,bkpt=3D@{number=3D"3",addr=3D"0x00010774",file=3D"recursive2.c, -@c "fullname=3D"/home/foo/recursive2.c",line=3D"11",thread-groups=3D["i1"], -@c times=3D"0"@} -@c (gdb) @end smallexample =20 @subheading The @code{-dprintf-insert} Command diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-br= eak.exp index 1c5eed3d4b0..b64fe196940 100644 --- a/gdb/testsuite/gdb.mi/mi-break.exp +++ b/gdb/testsuite/gdb.mi/mi-break.exp @@ -96,75 +96,6 @@ proc_with_prefix test_tbreak_creation_and_listing {} { "delete temp breakpoints" } =20 -proc_with_prefix test_rbreak_creation_and_listing {} { - global line_callee4_body - global line_callee3_body - global line_callee2_body - global line_callee1_body - global line_main_body - - # Insert some breakpoints and list them - # Also, disable some so they do not interfere with other tests - # Tests: - # -break-insert -r main - # -break-insert -r callee2 - # -break-insert -r callee - # -break-insert -r .*llee - # -break-list - - setup_kfail "*-*-*" mi/14270 - set bps {} - lappend bps [mi_make_breakpoint -number 5 -file ".*basics.c" \ - -line $line_main_body] - mi_gdb_test "122-break-insert -r main" \ - "122\\^done,[lindex $bps end]" \ - "break-insert -r operation" - - setup_kfail "*-*-*" mi/14270 - lappend bps [mi_make_breakpoint -number 6 -file ".*basics.c" \ - -line $line_callee2_body] - mi_gdb_test "133-break-insert -r callee2" \ - "133\\^done,[lindex $bps end]" \ - "insert breakpoint with regexp callee2" - - setup_kfail "*-*-*" mi/14270 - set start [llength $bps] - lappend bps [mi_make_breakpoint -number 7 -file ".*basics.c" \ - -line $line_callee1_body] - lappend bps [mi_make_breakpoint -number 8 -file ".*basics.c" \ - -line $line_callee2_body] - lappend bps [mi_make_breakpoint -number 9 -file ".*basics.c" \ - -line $line_callee3_body] - lappend bps [mi_make_breakpoint -number 10 -file ".*basics.c" \ - -line $line_callee4_body] - mi_gdb_test "144-break-insert -r callee" \ - "144\\^done,[join [lrange $bps $start end] ,]" \ - "insert breakpoint with regexp callee" - - setup_kfail "*-*-*" mi/14270 - set start [llength $bps] - lappend bps [mi_make_breakpoint -number 11 -file ".*basics.c" \ - -line $line_callee1_body] - lappend bps [mi_make_breakpoint -number 12 -file ".*basics.c" \ - -line $line_callee2_body] - lappend bps [mi_make_breakpoint -number 13 -file ".*basics.c" \ - -line $line_callee3_body] - lappend bps [mi_make_breakpoint -number 14 -file ".*basics.c" \ - -line $line_callee4_body] - mi_gdb_test "155-break-insert -r \.\*llee" \ - "155\\^done,[join [lrange $bps $start end] ,]" \ - "insert breakpoint with regexp .*llee" - - setup_kfail "*-*-*" mi/14270 - mi_gdb_test "166-break-list" \ - "166\\^done,[mi_make_breakpoint_table $bps]" \ - "list of breakpoints" - - mi_gdb_test "177-break-delete" \ - "177\\^done" \ - "delete temp breakpoints" -} - proc_with_prefix test_abreak_creation {} { mi_create_varobj tpnum \$tpnum "create local variable tpnum" # Test that $tpnum is not set before creating a tracepoint. @@ -478,7 +409,6 @@ proc test_break {mi_mode} { mi_gdb_load ${binfile} =20 test_tbreak_creation_and_listing - test_rbreak_creation_and_listing =20 test_ignore_count