public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Simplify varobj "change" logic Date: Mon, 6 Jun 2022 18:59:03 +0000 (GMT) [thread overview] Message-ID: <20220606185903.BDFF93856DC3@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a80f2680dbf07c713e3d58bc0906b7ed52f911e2 commit a80f2680dbf07c713e3d58bc0906b7ed52f911e2 Author: Tom Tromey <tromey@adacore.com> Date: Thu May 26 10:40:32 2022 -0600 Simplify varobj "change" logic varobj used to store 'print_value' as a C string, where NULL was a valid value, and so it had logic to handle this situation. However, at some point this was changed to be a std::string, and so the code can be simplified in this spot. Diff: --- gdb/varobj.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 741fdb6a03b..1aca015a21a 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -1344,11 +1344,8 @@ install_new_value (struct varobj *var, struct value *value, bool initial) { print_value = varobj_value_get_print_value (var->value.get (), var->format, var); - if ((var->print_value.empty () && !print_value.empty ()) - || (!var->print_value.empty () && print_value.empty ()) - || (!var->print_value.empty () && !print_value.empty () - && var->print_value != print_value)) - changed = true; + if (var->print_value != print_value) + changed = true; } var->print_value = print_value;
reply other threads:[~2022-06-06 18:59 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220606185903.BDFF93856DC3@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).