From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1983) id CF3A938582AC; Wed, 8 Jun 2022 14:56:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF3A938582AC Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Carl Love To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix gdb.arch/powerpc-power7.exp isel disassembly output. X-Act-Checkin: binutils-gdb X-Git-Author: Carl Love X-Git-Refname: refs/heads/master X-Git-Oldrev: bc2220c89de813bf67d4172a4c483d1e2b843366 X-Git-Newrev: cb50b0722c08b50f9693d7722426bdd0275d3841 Message-Id: <20220608145603.CF3A938582AC@sourceware.org> Date: Wed, 8 Jun 2022 14:56:03 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 14:56:03 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dcb50b0722c08= b50f9693d7722426bdd0275d3841 commit cb50b0722c08b50f9693d7722426bdd0275d3841 Author: Carl Love Date: Tue Jun 7 17:26:34 2022 -0500 Fix gdb.arch/powerpc-power7.exp isel disassembly output. =20 The following commit changes the output format for the isel instruction= on PowerPC. =20 commit dd4832bf3efc1bd1797a6b9188260692b8b0db52 Introduces error= in test Author: Dmitry Selyutin Date: Tue May 24 13:46:35 2022 +0000 =20 opcodes: introduce BC field; fix isel =20 Per Power ISA Version 3.1B 3.3.12, isel uses BC field rather tha= n CRB field present in binutils sources. Also, per 1.6.2, BC has the s= ame semantics as BA and BB fields, so this should keep the same flag= s and mask, only with the different offset. =20 opcodes/ * ppc-opc.c (BC): Define new field, with the same definition as CRB = field, but with the PPC_OPERAND_CR_BIT flag present. gas/ * testsuite/gas/ppc/476.d: Update. * testsuite/gas/ppc/a2.d: Update. * testsuite/gas/ppc/e500.d: Update. * testsuite/gas/ppc/power7.d: Update. --- a/gas/testsuite/gas/ppc/476.d +++ b/gas/testsuite/gas/ppc/476.d @@ -209,7 +209,7 @@ Disassembly of section \.text: .*: (7c 20 07 8c|8c 07 20 7c) ici 1 .*: (7c 03 27 cc|cc 27 03 7c) icread r3,r4 .*: (50 83 65 36|36 65 83 50) rlwimi r3,r4,12,20,27 -.*: (7c 43 27 1e|1e 27 43 7c) isel r2,r3,r4,28 +.*: (7c 43 27 1e|1e 27 43 7c) isel r2,r3,r4,4\*cr7\+lt =20 The above change breaks the gdb regression test gdb.arch/powerpc-power7= .exp on Power 7, Power 8, Power 9 and Power 10. =20 This patch updates the regression test gdb.arch/powerpc-power7.exp with the new expected output for the isel instruction. =20 The patch has been tested on Power 7 and Power 10 to verify the patch f= ixes the test. Diff: --- gdb/testsuite/gdb.arch/powerpc-power7.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.arch/powerpc-power7.exp b/gdb/testsuite/gdb.= arch/powerpc-power7.exp index f2f4525cd6e..10f7eebefc9 100644 --- a/gdb/testsuite/gdb.arch/powerpc-power7.exp +++ b/gdb/testsuite/gdb.arch/powerpc-power7.exp @@ -140,7 +140,7 @@ func_check "frsqrte f14,f15" func_check "frsqrte. f14,f15" func_check "frsqrtes f14,f15" func_check "frsqrtes. f14,f15" -func_check "isel r2,r3,r4,28" +func_check "isel r2,r3,r4,4*cr7+lt" func_check "yield" func_check "ori r2,r2,0" func_check "nop"