From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 00E0138BE6AE; Wed, 8 Jun 2022 19:04:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00E0138BE6AE Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: make throw_perror_with_name static X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: deb70aa0322c4c43b68fa859b52a0ccf2d904b0f X-Git-Newrev: 42d77edce1b4d49fed11fc79576ebe359f9b5f7f Message-Id: <20220608190456.00E0138BE6AE@sourceware.org> Date: Wed, 8 Jun 2022 19:04:56 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 19:04:56 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D42d77edce1b4= d49fed11fc79576ebe359f9b5f7f commit 42d77edce1b4d49fed11fc79576ebe359f9b5f7f Author: Andrew Burgess Date: Tue Jun 7 17:23:42 2022 +0100 gdb: make throw_perror_with_name static =20 The throw_perror_with_name function is not used outside of utils.c right now. And as perror_with_name is just a wrapper around throw_perror_with_name, then any future calls would be to perror_with_name. =20 Lets make throw_perror_with_name static. =20 There should be no user visible changes after this commit. Diff: --- gdb/utils.c | 2 +- gdb/utils.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/utils.c b/gdb/utils.c index f9dc4f23431..413a4f4d53b 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -623,7 +623,7 @@ perror_string (const char *prefix) as the file name for which the error was encountered. Use ERRCODE for the thrown exception. Then return to command level. */ =20 -void +static void ATTRIBUTE_NORETURN throw_perror_with_name (enum errors errcode, const char *string) { std::string combined =3D perror_string (string); diff --git a/gdb/utils.h b/gdb/utils.h index 7e2028580bf..d2acf899ba2 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -296,9 +296,6 @@ extern CORE_ADDR string_to_core_addr (const char *my_st= ring); extern void fprintf_symbol (struct ui_file *, const char *, enum language, int); =20 -extern void throw_perror_with_name (enum errors errcode, const char *strin= g) - ATTRIBUTE_NORETURN; - extern void perror_warning_with_name (const char *string); =20 extern void print_sys_errmsg (const char *, int);