public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: resolve duplicate test name in gnu_vector.exp Date: Thu, 9 Jun 2022 12:45:23 +0000 (GMT) [thread overview] Message-ID: <20220609124523.55009383A606@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=417d2514ef183c2beacd932651c6684743130ab6 commit 417d2514ef183c2beacd932651c6684743130ab6 Author: Andrew Burgess <aburgess@redhat.com> Date: Thu Jun 9 13:34:57 2022 +0100 gdb/testsuite: resolve duplicate test name in gnu_vector.exp While testing on AArch64 I spotted a duplicate test name in the gdb.base/gnu_vector.exp test. This commit adds a 'with_test_prefix' to resolve the duplicate. While I was in the area I updated a 'gdb_test_multiple' call to make use of $gdb_test_name. There should be no change in what is tested after this commit. Diff: --- gdb/testsuite/gdb.base/gnu_vector.exp | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/gdb/testsuite/gdb.base/gnu_vector.exp b/gdb/testsuite/gdb.base/gnu_vector.exp index b47be65cc1f..796d9e947e1 100644 --- a/gdb/testsuite/gdb.base/gnu_vector.exp +++ b/gdb/testsuite/gdb.base/gnu_vector.exp @@ -222,16 +222,18 @@ gdb_test "print add_structvecs(i2, (struct just_int2)\{2*i2\}, (struct two_int2) gdb_test "print add_singlevecs((char1) \{6\}, (int1) \{12\}, (double1) \{24\})" "= \\{42\\}" \ "call add_singlevecs" -# Test "finish" from vector-valued function. gdb_breakpoint "add_some_intvecs" -gdb_continue "add_some_intvecs" -set test "finish shows vector return value" -gdb_test_multiple "finish" $test { - -re "Value returned is .* = \\{10, 20, 48, 72\\}.*$gdb_prompt $" { - pass $test - } - -re "Value returned has type: .* Cannot determine contents.*$gdb_prompt $" { - kfail "gdb/8549" $test + +# Test "finish" from vector-valued function. +with_test_prefix "finish from vector function" { + gdb_continue "add_some_intvecs" + gdb_test_multiple "finish" "shows vector return value" { + -re "Value returned is .* = \\{10, 20, 48, 72\\}.*$gdb_prompt $" { + pass $gdb_test_name + } + -re "Value returned has type: .* Cannot determine contents.*$gdb_prompt $" { + kfail "gdb/8549" $gdb_test_name + } } }
reply other threads:[~2022-06-09 12:45 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220609124523.55009383A606@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).