public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Pedro Alves <palves@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix ARM_CC_FOR_TARGET handling Date: Thu, 9 Jun 2022 14:36:44 +0000 (GMT) [thread overview] Message-ID: <20220609143644.3924D3857034@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8db775b211bb01d06197bf6dabb6b32b5428d5e2 commit 8db775b211bb01d06197bf6dabb6b32b5428d5e2 Author: Pedro Alves <pedro@palves.net> Date: Thu Jun 9 15:32:52 2022 +0100 Fix ARM_CC_FOR_TARGET handling The previous patch that introduced the arm_cc_for_target procedure moved the ARM_CC_FOR_TARGET global check to that procedure, but forgot to tell tcl that ARM_CC_FOR_TARGET is a global. As a result, specifying ARM_CC_FOR_TARGET on the command line actually does nothing. This fixes it. Change-Id: I4e33b7633fa665e2f7b8f8c9592a949d74a19153 Diff: --- gdb/testsuite/lib/gdb.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 67e5838a7a7..37accd9947a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -8671,12 +8671,12 @@ proc get_set_option_choices {set_cmd} { # that the executable they produce can run. gdb_caching_proc arm_cc_for_target { - if {[info exists ARM_CC_FOR_TARGET]} { + if {[info exists ::ARM_CC_FOR_TARGET]} { # If the user specified the compiler explicitly, then don't # check whether the resulting binary runs outside GDB. Assume # that it does, and if it turns out it doesn't, then the user # should get loud FAILs, instead of UNSUPPORTED. - return $ARM_CC_FOR_TARGET + return $::ARM_CC_FOR_TARGET } # Fallback to a few common compiler names. Also confirm the
reply other threads:[~2022-06-09 14:36 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220609143644.3924D3857034@sourceware.org \ --to=palves@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).