From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1551) id 3924D3857034; Thu, 9 Jun 2022 14:36:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3924D3857034 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pedro Alves To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Fix ARM_CC_FOR_TARGET handling X-Act-Checkin: binutils-gdb X-Git-Author: Pedro Alves X-Git-Refname: refs/heads/master X-Git-Oldrev: 148ca9dd5cf96049c0db17c1230e4b96c0ac054a X-Git-Newrev: 8db775b211bb01d06197bf6dabb6b32b5428d5e2 Message-Id: <20220609143644.3924D3857034@sourceware.org> Date: Thu, 9 Jun 2022 14:36:44 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 14:36:44 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8db775b211bb= 01d06197bf6dabb6b32b5428d5e2 commit 8db775b211bb01d06197bf6dabb6b32b5428d5e2 Author: Pedro Alves Date: Thu Jun 9 15:32:52 2022 +0100 Fix ARM_CC_FOR_TARGET handling =20 The previous patch that introduced the arm_cc_for_target procedure moved the ARM_CC_FOR_TARGET global check to that procedure, but forgot to tell tcl that ARM_CC_FOR_TARGET is a global. As a result, specifying ARM_CC_FOR_TARGET on the command line actually does nothing. This fixes it. =20 Change-Id: I4e33b7633fa665e2f7b8f8c9592a949d74a19153 Diff: --- gdb/testsuite/lib/gdb.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 67e5838a7a7..37accd9947a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -8671,12 +8671,12 @@ proc get_set_option_choices {set_cmd} { # that the executable they produce can run. =20 gdb_caching_proc arm_cc_for_target { - if {[info exists ARM_CC_FOR_TARGET]} { + if {[info exists ::ARM_CC_FOR_TARGET]} { # If the user specified the compiler explicitly, then don't # check whether the resulting binary runs outside GDB. Assume # that it does, and if it turns out it doesn't, then the user # should get loud FAILs, instead of UNSUPPORTED. - return $ARM_CC_FOR_TARGET + return $::ARM_CC_FOR_TARGET } =20 # Fallback to a few common compiler names. Also confirm the