public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Yvan Roux <yroux@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/arm: Simplify logic for updating addresses Date: Thu, 9 Jun 2022 14:39:49 +0000 (GMT) [thread overview] Message-ID: <20220609143949.32801385C316@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1ef3351b7b11e3d3bcdccdbc1bf2690ce35a70ba commit 1ef3351b7b11e3d3bcdccdbc1bf2690ce35a70ba Author: Yvan Roux <yvan.roux@foss.st.com> Date: Thu Jun 9 16:34:53 2022 +0200 gdb/arm: Simplify logic for updating addresses Small performance improvement by fetching previous SP value only once before the loop and reuse it to avoid fetching at every iteration. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com> Signed-off-by: Yvan Roux <yvan.roux@foss.st.com> Diff: --- gdb/arm-tdep.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 09670b69a1d..23f3d5f02f2 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -2177,7 +2177,7 @@ arm_make_prologue_cache (struct frame_info *this_frame) { int reg; struct arm_prologue_cache *cache; - CORE_ADDR unwound_fp; + CORE_ADDR unwound_fp, prev_sp; cache = FRAME_OBSTACK_ZALLOC (struct arm_prologue_cache); arm_cache_init (cache, this_frame); @@ -2191,14 +2191,15 @@ arm_make_prologue_cache (struct frame_info *this_frame) arm_gdbarch_tdep *tdep = (arm_gdbarch_tdep *) gdbarch_tdep (get_frame_arch (this_frame)); - arm_cache_set_active_sp_value (cache, tdep, unwound_fp + cache->framesize); + prev_sp = unwound_fp + cache->framesize; + arm_cache_set_active_sp_value (cache, tdep, prev_sp); /* Calculate actual addresses of saved registers using offsets determined by arm_scan_prologue. */ for (reg = 0; reg < gdbarch_num_regs (get_frame_arch (this_frame)); reg++) if (cache->saved_regs[reg].is_addr ()) - cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () - + arm_cache_get_prev_sp_value (cache, tdep)); + cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () + + prev_sp); return cache; }
reply other threads:[~2022-06-09 14:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220609143949.32801385C316@sourceware.org \ --to=yroux@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).