public inbox for
help / color / mirror / Atom feed
* [binutils-gdb] Fix warning-avoidance initialization in xcoffread.c
@ 2022-06-10 20:38 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-06-10 20:38 UTC (permalink / raw)
  To: gdb-cvs;h=2cbde639ae207987fa169ad5ed70e53c11ecdcba

commit 2cbde639ae207987fa169ad5ed70e53c11ecdcba
Author: Tom Tromey <>
Date:   Sun Jun 5 11:12:57 2022 -0600

    Fix warning-avoidance initialization in xcoffread.c
    With the registry rewrite series, on Fedora 34, I started seeing this
    error in xcoffread.c:
    ../../binutils-gdb/gdb/xcoffread.c: In function ‘void read_xcoff_symtab(objfile*, legacy_psymtab*)’:
    ../../binutils-gdb/gdb/xcoffread.c:948:25: error: ‘main_aux’ is used uninitialized [-Werror=uninitialized]
      948 |   union internal_auxent fcn_aux_saved = main_aux;
          |                         ^~~~~~~~~~~~~
    ../../binutils-gdb/gdb/xcoffread.c:933:25: note: ‘main_aux’ declared here
      933 |   union internal_auxent main_aux;
          |                         ^~~~~~~~
    I don't know why this error started suddenly... that seems weird,
    because it's not obviously related to the changes I made.
    Looking into it, it seems this line was intended to avoid a similar
    warning -- but since 'main_aux' is uninitialized at the point where it
    is used, this fix was incomplete.
    This patch avoids the warning by initializing using "{}".  I'm
    checking this in.

 gdb/xcoffread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index e520d7ad40b..9e571d0419c 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -945,7 +945,7 @@ read_xcoff_symtab (struct objfile *objfile, legacy_psymtab *pst)
   struct xcoff_symbol fcn_stab_saved = { 0 };
   /* fcn_cs_saved is global because process_xcoff_symbol needs it.  */
-  union internal_auxent fcn_aux_saved = main_aux;
+  union internal_auxent fcn_aux_saved {};
   struct context_stack *newobj;
   const char *filestring = pst->filename;	/* Name of the current file.  */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-10 20:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 20:38 [binutils-gdb] Fix warning-avoidance initialization in xcoffread.c Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).