public inbox for
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Handle quotes in gdb_py_module_available
@ 2022-06-13 11:00 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-06-13 11:00 UTC (permalink / raw)
  To: gdb-cvs;h=f25123df34b037c7f5b3f25eddb7baa1de2befef

commit f25123df34b037c7f5b3f25eddb7baa1de2befef
Author: Tom de Vries <>
Date:   Mon Jun 13 12:59:56 2022 +0200

    [gdb/testsuite] Handle quotes in gdb_py_module_available
    On openSUSE Leap 42.3 with python 3.4, I run into:
    (gdb) python import pygments^M
    Traceback (most recent call last):^M
      File "<string>", line 1, in <module>^M
    ImportError: No module named 'pygments'^M
    Error while executing Python code.^M
    (gdb) FAIL: gdb.base/style.exp: python import pygments
    ERROR: unexpected output from python import
    because gdb_py_module_available doesn't handle the single quotes around the
    module name in the ImportError.
    Fix this by allowing the single quotes.
    Tested on x86_64-linux.

 gdb/testsuite/lib/gdb-python.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb-python.exp b/gdb/testsuite/lib/gdb-python.exp
index d5039bbd099..3f004283f08 100644
--- a/gdb/testsuite/lib/gdb-python.exp
+++ b/gdb/testsuite/lib/gdb-python.exp
@@ -61,7 +61,7 @@ proc gdb_py_module_available { name } {
 	-re -wrap "ModuleNotFoundError: No module named '${name}'.*" {
 	    set available false
-	-re -wrap "ImportError: No module named ${name}.*" {
+	-re -wrap "ImportError: No module named '?${name}'?.*" {
 	    set available false
 	-re -wrap "python import ${name}" {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-13 11:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 11:00 [binutils-gdb] [gdb/testsuite] Handle quotes in gdb_py_module_available Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).