public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: don't use bashism in configure test
Date: Mon, 13 Jun 2022 12:12:53 +0000 (GMT)	[thread overview]
Message-ID: <20220613121253.B3487382B261@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c714aff10b1a5542dac657d86eb56140945bbd65

commit c714aff10b1a5542dac657d86eb56140945bbd65
Author: Sam James <sam@gentoo.org>
Date:   Thu Jun 9 04:37:51 2022 +0100

    gdb: don't use bashism in configure test
    
    Results in configure output like:
    ```
    checking for X... no
    /var/tmp/portage/sys-devel/gdb-12.1/work/gdb-12.1/gdb/configure: 18837: test: yes: unexpected operator
    checking whether to use babeltrace... auto
    ```
    
    ... when /bin/sh is provided by a POSIX-compliant shell, like dash,
    instead of bash.

Diff:
---
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index 1008cbef28b..1b821390801 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -18760,7 +18760,7 @@ else
 fi
 
 
-if test "${enable_libbacktrace}" == "yes"; then
+if test "${enable_libbacktrace}" = "yes"; then
   LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
   LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
 
diff --git a/gdb/configure.ac b/gdb/configure.ac
index e3c19bc8859..bf03b875dfe 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -2113,7 +2113,7 @@ AC_ARG_ENABLE([libbacktrace],
 esac],
 enable_libbacktrace=yes)
 
-if test "${enable_libbacktrace}" == "yes"; then
+if test "${enable_libbacktrace}" = "yes"; then
   LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
   LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
   AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.])


                 reply	other threads:[~2022-06-13 12:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613121253.B3487382B261@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).