From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vries@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2205)
 id 6274D3858286; Mon, 13 Jun 2022 22:26:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6274D3858286
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.reverse/test_ioctl_TCSETSW.exp
 with libc debuginfo
X-Act-Checkin: binutils-gdb
X-Git-Author: Tom de Vries <tdevries@suse.de>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: c722093960edc1291df0a19ab0136fdb8934bdc2
X-Git-Newrev: c2ac533e98438df5e5c2c58cce104c927ad42d09
Message-Id: <20220613222650.6274D3858286@sourceware.org>
Date: Mon, 13 Jun 2022 22:26:50 +0000 (GMT)
X-BeenThere: gdb-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-cvs mailing list <gdb-cvs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-cvs/>
List-Help: <mailto:gdb-cvs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-cvs>,
 <mailto:gdb-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2022 22:26:50 -0000

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc2ac533e9843=
8df5e5c2c58cce104c927ad42d09

commit c2ac533e98438df5e5c2c58cce104c927ad42d09
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jun 14 00:26:46 2022 +0200

    [gdb/testsuite] Fix gdb.reverse/test_ioctl_TCSETSW.exp with libc debugi=
nfo
   =20
    When running test-case gdb.reverse/test_ioctl_TCSETSW.exp with glibc de=
buginfo
    installed, I run into:
    ...
    (gdb) PASS: gdb.reverse/test_ioctl_TCSETSW.exp: at TCSETSW call
    step^M
    __tcsetattr (fd=3D0, optional_actions=3D1, termios_p=3D0x7fffffffcf50) =
at \
      ../sysdeps/unix/sysv/linux/tcsetattr.c:45^M
    45      {^M
    (gdb) FAIL: gdb.reverse/test_ioctl_TCSETSW.exp: handle TCSETSW
    ...
   =20
    The problem is that the step is expected to step over the call to tcset=
attr,
    but due to glibc debuginfo being installed, we step into the call.
   =20
    Fix this by using next instead of step.
   =20
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp b/gdb/testsui=
te/gdb.reverse/test_ioctl_TCSETSW.exp
index 86a62ebe5e5..4a81a618efc 100644
--- a/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp
+++ b/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.exp
@@ -35,7 +35,7 @@ gdb_test "break $stop" ".*Breakpoint .*" "stop at TCSETSW"
 gdb_test "continue"  ".*Breakpoint .*" "at TCSETSW call"
=20
 set test "handle TCSETSW"
-gdb_test_multiple "step"  $test {
+gdb_test_multiple "next"  $test {
     -re "Process record and replay target doesn't support ioctl request 0x=
.*$gdb_prompt $" {
 	fail $test
     }