public inbox for
help / color / mirror / Atom feed
From: Tom de Vries <>
Subject: [binutils-gdb] [gdb/testsuite] Fix regexp in gdb.ada/mi_var_access.exp
Date: Tue, 14 Jun 2022 09:06:35 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=c5a72a8d1c321fcf8ea1c5dc742f273a7429fd56

commit c5a72a8d1c321fcf8ea1c5dc742f273a7429fd56
Author: Tom de Vries <>
Date:   Tue Jun 14 11:06:26 2022 +0200

    [gdb/testsuite] Fix regexp in gdb.ada/mi_var_access.exp
    With gcc-12 and target board unix/-m32, we run into:
    (gdb) ^M
    Expecting: ^(-var-create A_String_Access \* A_String_Access[^M
    ]+[(]gdb[)] ^M
    [ ]*)
    -var-create A_String_Access * A_String_Access^M
    ^error,msg="Value out of range."^M
    (gdb) ^M
    FAIL: gdb.ada/mi_var_access.exp: Create varobj (unexpected output)
    What happens is easier to understand if we take things out of the mi context:
    $ gdb -q -batch \
        outputs/gdb.ada/mi_var_access/mi_access \
        -ex "b mi_access.adb:19" \
        -ex run \
        -ex "p A_String_Access"
    Breakpoint 1, mi_access () at mi_access.adb:19
    19         A_String : String (3 .. 5) := "345"; -- STOP
    $1 = (pck.string_access) <error reading variable: Value out of range.>
    while with target board unix we have instead:
    $1 = (pck.string_access) 0x431b40 <ada_main.sec_default_sized_stacks>
    The var-create command samples the value of the variable at a location where
    the variable is not yet initialized, and with target board unix we
    accidentally hit a valid address, but with target board unix/-m32 that's not
    the case.
    Fix the FAIL by accepting the error message.

 gdb/testsuite/gdb.ada/mi_var_access.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.ada/mi_var_access.exp b/gdb/testsuite/gdb.ada/mi_var_access.exp
index 7a9fe7f7f60..0d5e4e949d6 100644
--- a/gdb/testsuite/gdb.ada/mi_var_access.exp
+++ b/gdb/testsuite/gdb.ada/mi_var_access.exp
@@ -40,8 +40,10 @@ mi_continue_to_line \
     "stop at start of mi_access"
 # The bug was that creating a varobj for A_String_Access would crash.
+set re_ok "\\^done,name=\"A_String_Access\",numchild=\"1\",.*"
+set re_error "\\^error,msg=\"Value out of range\.\".*"
 mi_gdb_test "-var-create A_String_Access * A_String_Access" \
-    "\\^done,name=\"A_String_Access\",numchild=\"1\",.*" \
+    "($re_ok|$re_error)" \
     "Create varobj"
 set bp_location [gdb_get_line_number "STOP2" ${testdir}/mi_access.adb]

                 reply	other threads:[~2022-06-14  9:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).