From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id D034D383F946; Tue, 14 Jun 2022 15:04:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D034D383F946 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Allow 'interrupt -a' in all-stop mode X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: e5ab6af52d38ee068c1860ef113b7db4cc985cfb X-Git-Newrev: edb6b77c755545afb969fcebfa900b07a4b93c94 Message-Id: <20220614150419.D034D383F946@sourceware.org> Date: Tue, 14 Jun 2022 15:04:19 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 15:04:19 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dedb6b77c7555= 45afb969fcebfa900b07a4b93c94 commit edb6b77c755545afb969fcebfa900b07a4b93c94 Author: Tom Tromey Date: Wed Jun 8 09:26:08 2022 -0600 Allow 'interrupt -a' in all-stop mode =20 PR gdb/17160 points out that "interrupt -a" errors in all-stop mode, but there's no good reason for this. This patch removes the error. =20 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D17160 Diff: --- gdb/infcmd.c | 3 --- gdb/testsuite/gdb.base/interrupt-a.c | 27 +++++++++++++++++++ gdb/testsuite/gdb.base/interrupt-a.exp | 47 ++++++++++++++++++++++++++++++= ++++ 3 files changed, 74 insertions(+), 3 deletions(-) diff --git a/gdb/infcmd.c b/gdb/infcmd.c index e909d4d4c81..18590259339 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2874,9 +2874,6 @@ interrupt_command (const char *args, int from_tty) && startswith (args, "-a")) all_threads =3D 1; =20 - if (!non_stop && all_threads) - error (_("-a is meaningless in all-stop mode.")); - interrupt_target_1 (all_threads); } } diff --git a/gdb/testsuite/gdb.base/interrupt-a.c b/gdb/testsuite/gdb.base/= interrupt-a.c new file mode 100644 index 00000000000..2c12df28f2c --- /dev/null +++ b/gdb/testsuite/gdb.base/interrupt-a.c @@ -0,0 +1,27 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . = */ + +#include + +int +main () +{ + int i; + + for (i =3D 0; i < 60; ++i) + sleep (50); +} diff --git a/gdb/testsuite/gdb.base/interrupt-a.exp b/gdb/testsuite/gdb.bas= e/interrupt-a.exp new file mode 100644 index 00000000000..e134f6ead1f --- /dev/null +++ b/gdb/testsuite/gdb.base/interrupt-a.exp @@ -0,0 +1,47 @@ +# Copyright (C) 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that 'interrupt -a' works in all stop mode. + +standard_testfile .c +set executable ${testfile} + +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}]} { + return -1 +} + +if {![runto_main]} { + return -1 +} + +gdb_test_multiple "continue &" "" { + -re "Continuing\\.\r\n$gdb_prompt " { + pass $gdb_test_name + } +} + +after 200 + +gdb_test_multiple "interrupt -a" "" { + -re "$gdb_prompt " { + pass $gdb_test_name + } +} + +gdb_test_multiple "" "inferior stopped" { + -re "Program received signal" { + pass $gdb_test_name + } +}