public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Check for listeners in emit_exiting_event
Date: Wed, 15 Jun 2022 20:07:58 +0000 (GMT)	[thread overview]
Message-ID: <20220615200758.2544038582B4@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9d741cbedb8a7a77bb7c99bbbc363d5af4ba62c2

commit 9d741cbedb8a7a77bb7c99bbbc363d5af4ba62c2
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Jun 3 10:39:11 2022 -0600

    Check for listeners in emit_exiting_event
    
    I noticed that emit_exiting_event does not check whether there are any
    listeners before creating the event object.  All other event emitters
    do this, so this patch updates this one as well.

Diff:
---
 gdb/python/python.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/python/python.c b/gdb/python/python.c
index 079c260fc7f..7faad2bfa35 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1938,6 +1938,9 @@ init__gdb_module (void)
 static int
 emit_exiting_event (int exit_code)
 {
+  if (evregpy_no_listeners_p (gdb_py_events.gdb_exiting))
+    return 0;
+
   gdbpy_ref<> event_obj = create_event_object (&gdb_exiting_event_object_type);
   if (event_obj == nullptr)
     return -1;


                 reply	other threads:[~2022-06-15 20:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220615200758.2544038582B4@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).