public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use PyBool_FromLong Date: Thu, 23 Jun 2022 15:45:25 +0000 (GMT) [thread overview] Message-ID: <20220623154525.B8B2D38560AF@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c86acd3f180419c3d9825170492363fe2322fa8d commit c86acd3f180419c3d9825170492363fe2322fa8d Author: Tom Tromey <tromey@adacore.com> Date: Tue Jun 7 09:15:24 2022 -0600 Use PyBool_FromLong I noticed a few spots that were explicitly creating new references to Py_True or Py_False. It's simpler here to use PyBool_FromLong, so this patch changes all the places I found. Diff: --- gdb/python/py-cmd.c | 3 +-- gdb/python/py-symbol.c | 3 +-- gdb/python/py-type.c | 6 ++---- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c index f80318374d3..5cc392af175 100644 --- a/gdb/python/py-cmd.c +++ b/gdb/python/py-cmd.c @@ -128,8 +128,7 @@ cmdpy_function (const char *args, int from_tty, cmd_list_element *command) error (_("Could not convert arguments to Python string.")); } - gdbpy_ref<> ttyobj - = gdbpy_ref<>::new_reference (from_tty ? Py_True : Py_False); + gdbpy_ref<> ttyobj (PyBool_FromLong (from_tty)); gdbpy_ref<> result (PyObject_CallMethodObjArgs ((PyObject *) obj, invoke_cst, argobj.get (), ttyobj.get (), NULL)); diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index 02c35acd1e9..23495b66d42 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -426,8 +426,7 @@ gdbpy_lookup_symbol (PyObject *self, PyObject *args, PyObject *kw) } PyTuple_SET_ITEM (ret_tuple.get (), 0, sym_obj); - bool_obj = (is_a_field_of_this.type != NULL) ? Py_True : Py_False; - Py_INCREF (bool_obj); + bool_obj = PyBool_FromLong (is_a_field_of_this.type != NULL); PyTuple_SET_ITEM (ret_tuple.get (), 1, bool_obj); return ret_tuple.release (); diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c index 5352ead84bd..0e772ad44b4 100644 --- a/gdb/python/py-type.c +++ b/gdb/python/py-type.c @@ -220,14 +220,12 @@ convert_field (struct type *type, int field) if (PyObject_SetAttrString (result.get (), "name", arg.get ()) < 0) return NULL; - arg = gdbpy_ref<>::new_reference (TYPE_FIELD_ARTIFICIAL (type, field) - ? Py_True : Py_False); + arg.reset (PyBool_FromLong (TYPE_FIELD_ARTIFICIAL (type, field))); if (PyObject_SetAttrString (result.get (), "artificial", arg.get ()) < 0) return NULL; if (type->code () == TYPE_CODE_STRUCT) - arg = gdbpy_ref<>::new_reference (field < TYPE_N_BASECLASSES (type) - ? Py_True : Py_False); + arg.reset (PyBool_FromLong (field < TYPE_N_BASECLASSES (type))); else arg = gdbpy_ref<>::new_reference (Py_False); if (PyObject_SetAttrString (result.get (), "is_base_class", arg.get ()) < 0)
reply other threads:[~2022-06-23 15:45 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220623154525.B8B2D38560AF@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).