From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1551) id 3C33E385742C; Fri, 24 Jun 2022 10:25:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C33E385742C Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Pedro Alves To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Delete delete_thread_silent X-Act-Checkin: binutils-gdb X-Git-Author: Pedro Alves X-Git-Refname: refs/heads/master X-Git-Oldrev: 54603ee2aeaf248220f0f440c322ff02e98cd403 X-Git-Newrev: 39b8a8090ed7e8967ceca3655aa5f3a2ae91219d Message-Id: <20220624102553.3C33E385742C@sourceware.org> Date: Fri, 24 Jun 2022 10:25:53 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 10:25:53 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D39b8a8090ed7= e8967ceca3655aa5f3a2ae91219d commit 39b8a8090ed7e8967ceca3655aa5f3a2ae91219d Author: Pedro Alves Date: Wed Jun 22 18:20:42 2022 +0100 Delete delete_thread_silent =20 delete_thread_silent is no longer used anywhere. Delete it. =20 Change-Id: Iafcec12339861d5ab2e29c14d7b1f884c9e11c0f Diff: --- gdb/gdbthread.h | 4 ---- gdb/thread.c | 28 +++++----------------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index 1a33eb61221..1f17ad7d9e7 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -623,10 +623,6 @@ extern struct thread_info *add_thread_with_info (proce= ss_stratum_target *targ, as exited and do the notification. */ extern void delete_thread (struct thread_info *thread); =20 -/* Like delete_thread, but be quiet about it. Used when the process - this thread belonged to has already exited, for example. */ -extern void delete_thread_silent (struct thread_info *thread); - /* Mark the thread exited, but don't delete it or remove it from the inferior thread list. */ extern void set_thread_exited (thread_info *tp, bool silent); diff --git a/gdb/thread.c b/gdb/thread.c index 378c5ee2d13..f0ad82e76d7 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -450,20 +450,16 @@ global_thread_step_over_chain_remove (struct thread_i= nfo *tp) global_thread_step_over_list.erase (it); } =20 -/* Delete the thread referenced by THR. If SILENT, don't notify - the observer of this exit. - =20 - THR must not be NULL or a failed assertion will be raised. */ +/* See gdbthread.h. */ =20 -static void -delete_thread_1 (thread_info *thr, bool silent) +void +delete_thread (thread_info *thr) { gdb_assert (thr !=3D nullptr); =20 - threads_debug_printf ("deleting thread %s, silent =3D %d", - thr->ptid.to_string ().c_str (), silent); + threads_debug_printf ("deleting thread %s", thr->ptid.to_string ().c_str= ()); =20 - set_thread_exited (thr, silent); + set_thread_exited (thr, false); =20 if (!thr->deletable ()) { @@ -477,20 +473,6 @@ delete_thread_1 (thread_info *thr, bool silent) delete thr; } =20 -/* See gdbthread.h. */ - -void -delete_thread (thread_info *thread) -{ - delete_thread_1 (thread, false /* not silent */); -} - -void -delete_thread_silent (thread_info *thread) -{ - delete_thread_1 (thread, true /* silent */); -} - struct thread_info * find_thread_global_id (int global_id) {