public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
Date: Mon, 27 Jun 2022 10:47:57 +0000 (GMT)	[thread overview]
Message-ID: <20220627104757.E415F38418A0@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=772f8196d621a8009035ff4cb8aab2d7343269a9

commit 772f8196d621a8009035ff4cb8aab2d7343269a9
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Jun 27 12:47:26 2022 +0200

    [gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie
    
    When running test-case gdb.reverse/i387-env-reverse.exp for x86_64-linux with
    target board unix/-m32/-fPIE/-pie, we run into:
    ...
    (gdb) PASS: gdb.reverse/i387-env-reverse.exp: push st0
    info register eax^M
    eax            0x56550000          1448411136^M
    (gdb) FAIL: gdb.reverse/i387-env-reverse.exp: verify eax == 0x8040000
    ...
    
    The problem is that the tested instruction (fstsw) only sets $ax, not $eax.
    
    Fix this by verifying $ax instead of $eax.
    
    Tested on x86_64-linux with target boards unix/-m32 and unix/-m32/-fPIE/-pie.

Diff:
---
 gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
index a0a79c22ed0..53fee0986df 100644
--- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
@@ -64,7 +64,7 @@ with_test_prefix "forward" {
     gdb_test "n" "asm.*fstsw.*"               "store status word in EAX"
     gdb_test "n" "asm.*fld1.*"                "push st0"
 
-    gdb_test "info register eax" "eax *0x8040000.*\[ \t\]+.*"  "verify eax == 0x8040000"
+    gdb_test "info register ax" "ax *0x0.*\[ \t\]+.*"  "verify eax == 0x0"
     gdb_test "info register fstat" "fstat *0.*\[ \t\]+.*"      "verify fstat == 0"
     gdb_test "info register ftag" "ftag *0xffff.*\[ \t\]+.*"   "verify ftag == 0xffff"


                 reply	other threads:[~2022-06-27 10:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627104757.E415F38418A0@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).