public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/build] Fix gdb build with -fsanitize=thread and gcc 7
@ 2022-06-28 15:07 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-06-28 15:07 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9117c7b452ef76304f4394a97c887d0c4af439f5

commit 9117c7b452ef76304f4394a97c887d0c4af439f5
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jun 28 17:07:18 2022 +0200

    [gdb/build] Fix gdb build with -fsanitize=thread and gcc 7
    
    When building gdb with system gcc 7.5.0, I run into:
    ...
    gdb/ia64-tdep.c: In function ‘int is_float_or_hfa_type_recurse(type*, type**)’:
    gdb/ia64-tdep.c:3362:1: error: control reaches end of non-void function \
      [-Werror=return-type]
    ...
    
    This is due to PR gcc/81275 - "-fsanitize=thread produce incorrect
    -Wreturn-type warning", which has been fixed in gcc-8.
    
    Work around this by moving the default return outside the switch.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/ia64-tdep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c
index 82456dc9c98..b94225b5e13 100644
--- a/gdb/ia64-tdep.c
+++ b/gdb/ia64-tdep.c
@@ -3356,9 +3356,10 @@ is_float_or_hfa_type_recurse (struct type *t, struct type **etp)
       }
       break;
     default:
-      return 0;
       break;
     }
+
+  return 0;
 }
 
 /* Determine if the given type is one of the floating point types or


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-28 15:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 15:07 [binutils-gdb] [gdb/build] Fix gdb build with -fsanitize=thread and gcc 7 Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).