public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Maciej W. Rozycki <macro@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] GDB/testsuite: Tighten `set print elements' error check
Date: Wed, 29 Jun 2022 14:29:02 +0000 (GMT)	[thread overview]
Message-ID: <20220629142902.5B7DF384F018@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b955c336f93a1b8ab433b713739c145c56f5c027

commit b955c336f93a1b8ab433b713739c145c56f5c027
Author: Maciej W. Rozycki <macro@embecosm.com>
Date:   Wed Jun 29 15:27:41 2022 +0100

    GDB/testsuite: Tighten `set print elements' error check
    
    Match the whole error message expected to be given rather than omitting
    the part about the "unlimited" keyword.  There's no point in omitting
    the missing part first, and second with an upcoming change the part in
    parentheses will no longer be a fixed string, so doing a full match will
    ensure the algorithm correctly builds the message expected here.  Also
    avoid any wildcard matches.

Diff:
---
 gdb/testsuite/gdb.base/default.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index 23379f6ec01..e1e0d311b6c 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -525,7 +525,8 @@ gdb_test_no_output "set print asm-demangle" "set print asm-demangle"
 #test set print demangle
 gdb_test_no_output "set print demangle" "set print demangle"
 #test set print elements
-gdb_test "set print elements" "Argument required .integer to set it to.*"
+gdb_test "set print elements" \
+	 "Argument required \\(integer to set it to, or \"unlimited\"\\)\\."
 #test set print object
 gdb_test_no_output "set print object" "set print object"
 #test set print pretty


                 reply	other threads:[~2022-06-29 14:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629142902.5B7DF384F018@sourceware.org \
    --to=macro@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).