public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: initialize the data_head variable to eliminate compilation warnings
@ 2022-07-08 13:49 Enze Li
  0 siblings, 0 replies; only message in thread
From: Enze Li @ 2022-07-08 13:49 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=44ca285b73b68f6a8fa3e89004b510d6b7d98e91

commit 44ca285b73b68f6a8fa3e89004b510d6b7d98e91
Author: Enze Li <enze.li@hotmail.com>
Date:   Sat Jun 11 18:36:48 2022 +0800

    gdb: initialize the data_head variable to eliminate compilation warnings
    
    On a machine with gcc 12, I get this warning:
    
      CXX    nat/linux-btrace.o
    In function ‘btrace_error linux_read_bts(btrace_data_bts*, btrace_target_info*, btrace_read_type)’,
        inlined from ‘btrace_error linux_read_btrace(btrace_data*, btrace_target_info*, btrace_read_type)’ at ../gdb/nat/linux-btrace.c:935:29:
    ../gdb/nat/linux-btrace.c:865:21: warning: ‘data_head’ may be used uninitialized [-Wmaybe-uninitialized]
      865 |   pevent->last_head = data_head;
          |   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
    ../gdb/nat/linux-btrace.c: In function ‘btrace_error linux_read_btrace(btrace_data*, btrace_target_info*, btrace_read_type)’:
    ../gdb/nat/linux-btrace.c:792:9: note: ‘data_head’ was declared here
      792 |   __u64 data_head, data_tail;
          |         ^~~~~~~~~
    
    Fix this by initializing the 'data_head' variable.
    
    Tested by rebuilding on x86_64 openSUSE Tumbleweed with gcc 12.

Diff:
---
 gdb/nat/linux-btrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c
index b0d6dcd7cf1..c31fb5ffe43 100644
--- a/gdb/nat/linux-btrace.c
+++ b/gdb/nat/linux-btrace.c
@@ -789,7 +789,7 @@ linux_read_bts (struct btrace_data_bts *btrace,
   struct perf_event_buffer *pevent;
   const uint8_t *begin, *end, *start;
   size_t buffer_size, size;
-  __u64 data_head, data_tail;
+  __u64 data_head = 0, data_tail;
   unsigned int retries = 5;
 
   pevent = &tinfo->variant.bts.bts;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-08 13:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-08 13:49 [binutils-gdb] gdb: initialize the data_head variable to eliminate compilation warnings Enze Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).