public inbox for
help / color / mirror / Atom feed
From: Tom de Vries <>
Subject: [binutils-gdb] [gdb/build] Fix gdb build with gcc 4.8.5
Date: Thu, 14 Jul 2022 08:20:20 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=2df41bda2f80a1fbd443c44ee1bd54da579fc8a2

commit 2df41bda2f80a1fbd443c44ee1bd54da579fc8a2
Author: Tom de Vries <>
Date:   Thu Jul 14 10:20:16 2022 +0200

    [gdb/build] Fix gdb build with gcc 4.8.5
    When building gdb with gcc 4.8.5, we run into:
    In file included from /usr/include/c++/4.8/future:43:0,
                     from gdbsupport/thread-pool.h:30,
                     from gdb/dwarf2/cooked-index.h:33,
                     from gdb/dwarf2/read.h:26,
                     from gdb/dwarf2/abbrev-cache.c:21:
    /usr/include/c++/4.8/atomic: In instantiation of \
      ‘_Tp std::atomic<_Tp>::load(std::memory_order) const [with _Tp = \
      packed<dwarf_unit_type, 1ul>; std::memory_order = std::memory_order]’:
    gdb/dwarf2/read.h:332:44:   required from here
    /usr/include/c++/4.8/atomic:208:13: error: no matching function for call to \
      ‘packed<dwarf_unit_type, 1ul>::packed()’
             _Tp tmp;
    Fix this by adding the default constructor for packed.
    Tested on x86_64-linux, with gdb build with gcc 4.8.5.

 gdbsupport/packed.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdbsupport/packed.h b/gdbsupport/packed.h
index cd331b5477d..3468cf44207 100644
--- a/gdbsupport/packed.h
+++ b/gdbsupport/packed.h
@@ -31,6 +31,8 @@ template<typename T, size_t Bytes = sizeof (T)>
 struct packed
+  packed () noexcept = default;
   packed (T val)
     m_val = val;

                 reply	other threads:[~2022-07-14  8:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).