public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb-add-index always generates an error when libdebuginfod wasn't compiled in
@ 2022-07-15 21:36 Aaron Merey
  0 siblings, 0 replies; only message in thread
From: Aaron Merey @ 2022-07-15 21:36 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=92b0a182fe00da3022516f3cb8f815d527d73652

commit 92b0a182fe00da3022516f3cb8f815d527d73652
Author: Aaron Merey <amerey@redhat.com>
Date:   Tue Jul 5 18:11:49 2022 -0400

    gdb-add-index always generates an error when libdebuginfod wasn't compiled in
    
    gdb-add-index runs gdb with -iex 'set debuginfod enabled off'.  If gdb
    is not compiled against libdebuginfod this causes an unnecessary error
    message to be printed to stderr indicating that gdb was not built with
    debuginfod support.
    
    Fix this by changing the 'set debuginfod enabled off' command to a
    no-op when gdb isn't built with libdebuginfod.

Diff:
---
 gdb/debuginfod-support.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 9dbe6b5d8b2..5f04a2b38ca 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -368,7 +368,9 @@ set_debuginfod_enabled (const char *value)
 #if defined(HAVE_LIBDEBUGINFOD)
   debuginfod_enabled = value;
 #else
-  error (NO_IMPL);
+  /* Disabling debuginfod when gdb is not built with it is a no-op.  */
+  if (value != debuginfod_off)
+    error (NO_IMPL);
 #endif
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-15 21:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 21:36 [binutils-gdb] gdb-add-index always generates an error when libdebuginfod wasn't compiled in Aaron Merey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).