[binutils-gdb] Put gdb.base/bt-on-fatal-signal.exp GDB cores in output dir

[binutils-gdb] Put gdb.base/bt-on-fatal-signal.exp GDB cores in output dir

[Pedro Alves]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=23948f56021f46bb2bdee7afad074aafe8329230

commit 23948f56021f46bb2bdee7afad074aafe8329230
Author: Pedro Alves <pedro@palves.net>
Date:   Wed Jul 13 16:45:21 2022 +0100

    Put gdb.base/bt-on-fatal-signal.exp GDB cores in output dir
    
    I noticed that gdb.base/bt-on-fatal-signal.exp was contributing four
    core files to the count of unexpected core files:
    
     $ make check TESTS="gdb.base/bt-on-fatal-signal.exp"
    
                     === gdb Summary ===
    
     # of unexpected core files      4
     # of expected passes            21
    
    These are GDB core dumps.  They are expected, however, because the
    whole point of the testcase is to crash GDB with a signal.
    
    Make GDB change its current directory to the output dir just before
    crashing, so that the core files end up there.  The result is now:
    
                     === gdb Summary ===
    
     # of expected passes            25
    
    and:
    
     $ find . -name "core.*"
     ./testsuite/outputs/gdb.base/bt-on-fatal-signal/core.gdb.1676506.nelson.1657727692
     ./testsuite/outputs/gdb.base/bt-on-fatal-signal/core.gdb.1672585.nelson.1657727671
     ./testsuite/outputs/gdb.base/bt-on-fatal-signal/core.gdb.1674833.nelson.1657727683
     ./testsuite/outputs/gdb.base/bt-on-fatal-signal/core.gdb.1673709.nelson.1657727676
    
    (Note the test is skipped at the top if on a remote host.)
    
    Change-Id: I79e4fb2e91330279c7a509930b1952194a72e85a

Diff:
---
 gdb/testsuite/gdb.base/bt-on-fatal-signal.exp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp b/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp
index 8adf3c4fa45..8f9d857106d 100644
--- a/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp
+++ b/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp
@@ -80,6 +80,11 @@ foreach test_data {{SEGV "Segmentation fault"} \
 	set saw_bt_end false
 	set internal_error_msg_count 0
 
+	# Get the GDB core into the output directory, so that it
+	# doesn't count as unexpected core in gdb.sum.
+	gdb_test "cd [file dirname $binfile]" "Working directory .*" \
+	    "cd to test directory"
+
 	# Send the fatal signal to GDB.
 	remote_exec host "kill -${sig} ${testpid}"