public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Remove dead code from windows_nat_target::detach Date: Mon, 25 Jul 2022 13:30:21 +0000 (GMT) [thread overview] Message-ID: <20220725133021.C275D3875A3D@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=eea2d83593428d2ac18f6b3fc43cff5472521579 commit eea2d83593428d2ac18f6b3fc43cff5472521579 Author: Tom Tromey <tromey@adacore.com> Date: Fri Jul 22 12:55:27 2022 -0600 Remove dead code from windows_nat_target::detach windows_nat_target::detach has a variable 'detached' that is only set after a call to 'error'. However, this can't happen because 'error' throws an exception. This patch removes the dead code. Diff: --- gdb/windows-nat.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 43a2c112db5..9265ed9e632 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1912,22 +1912,16 @@ windows_nat_target::attach (const char *args, int from_tty) void windows_nat_target::detach (inferior *inf, int from_tty) { - int detached = 1; - ptid_t ptid = minus_one_ptid; resume (ptid, 0, GDB_SIGNAL_0); if (!DebugActiveProcessStop (windows_process.current_event.dwProcessId)) - { - error (_("Can't detach process %u (error %u)"), - (unsigned) windows_process.current_event.dwProcessId, - (unsigned) GetLastError ()); - detached = 0; - } + error (_("Can't detach process %u (error %u)"), + (unsigned) windows_process.current_event.dwProcessId, + (unsigned) GetLastError ()); DebugSetProcessKillOnExit (FALSE); - if (detached) - target_announce_detach (from_tty); + target_announce_detach (from_tty); x86_cleanup_dregs (); switch_to_no_thread ();
reply other threads:[~2022-07-25 13:30 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220725133021.C275D3875A3D@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).