public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Enze Li <lienze@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/netbsd: add missing header file
Date: Tue, 26 Jul 2022 12:24:42 +0000 (GMT)	[thread overview]
Message-ID: <20220726122442.A1EE33858D32@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=de69cec0c53f1ef5cb242bfc969723b7dba4defb

commit de69cec0c53f1ef5cb242bfc969723b7dba4defb
Author: Enze Li <enze.li@hotmail.com>
Date:   Sun Jul 24 10:38:19 2022 +0800

    gdb/netbsd: add missing header file
    
    I ran into this error when building GDB on NetBSD:
    
      CXX    netbsd-nat.o
    netbsd-nat.c: In member function 'virtual bool nbsd_nat_target::info_proc(const char*, info_proc_what)':
    netbsd-nat.c:314:3: error: 'gdb_argv' was not declared in this scope
       gdb_argv built_argv (args);
       ^~~~~~~~
    netbsd-nat.c:314:3: note: suggested alternative: 'gdbarch'
       gdb_argv built_argv (args);
       ^~~~~~~~
       gdbarch
    netbsd-nat.c:315:7: error: 'built_argv' was not declared in this scope
       if (built_argv.count () == 0)
           ^~~~~~~~~~
    netbsd-nat.c:315:7: note: suggested alternative: 'buildargv'
       if (built_argv.count () == 0)
           ^~~~~~~~~~
           buildargv
    gmake[2]: *** [Makefile:1893: netbsd-nat.o] Error 1
    
    Fix this by adding the missing header file, as it is obvious.
    
    Tested by rebuilding on NetBSD/amd64.

Diff:
---
 gdb/netbsd-nat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c
index c45df391afc..8a4a43270d6 100644
--- a/gdb/netbsd-nat.c
+++ b/gdb/netbsd-nat.c
@@ -25,6 +25,7 @@
 #include "netbsd-tdep.h"
 #include "inferior.h"
 #include "gdbarch.h"
+#include "gdbsupport/buildargv.h"
 
 #include <sys/types.h>
 #include <sys/ptrace.h>


                 reply	other threads:[~2022-07-26 12:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220726122442.A1EE33858D32@sourceware.org \
    --to=lienze@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).