public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang
@ 2022-07-26 13:02 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-07-26 13:02 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=206977b2edecbe086beb23a32c9c114e2d5af28d

commit 206977b2edecbe086beb23a32c9c114e2d5af28d
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Jul 26 15:02:18 2022 +0200

    [gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang
    
    When running test-case gdb.opt/inline-small-func.exp with clang 12.0.1, I run
    into:
    ...
    gdb compile failed, /usr/bin/ld: inline-small-func0.o: in function `main':
    inline-small-func.c:21: undefined reference to `callee'
    clang-12.0: error: linker command failed with exit code 1 \
      (use -v to see invocation)
    UNTESTED: gdb.opt/inline-small-func.exp: failed to prepare
    ...
    
    Fix this by using __attribute__((always_inline)).
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.opt/inline-small-func.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.opt/inline-small-func.h b/gdb/testsuite/gdb.opt/inline-small-func.h
index 66323952cf4..44b6e86fc15 100644
--- a/gdb/testsuite/gdb.opt/inline-small-func.h
+++ b/gdb/testsuite/gdb.opt/inline-small-func.h
@@ -13,9 +13,15 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#ifdef __GNUC__
+#define ATTR __attribute__((always_inline))
+#else
+#define ATTR
+#endif
+
 int counter = 42;
 
-inline void
+inline ATTR void
 callee () {
   counter = 0;	/* callee: body.  */
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-26 13:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 13:02 [binutils-gdb] [gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).