public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/gdb_mbuild.sh: use return instead of continue to avoid shellcheck error
Date: Thu, 28 Jul 2022 14:31:16 +0000 (GMT)	[thread overview]
Message-ID: <20220728143116.C8C67385AE5A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8727caedd18a93826a825efbfec33aea3b8f3109

commit 8727caedd18a93826a825efbfec33aea3b8f3109
Author: yaowenbin <yaowenbin1@huawei.com>
Date:   Thu Jul 28 17:22:47 2022 +0800

    gdb/gdb_mbuild.sh: use return instead of continue to avoid shellcheck error
    
    Fix:
    
        In gdb_mbuild.sh line 174:
                    continue
                    ^------^ SC2104 (error): In functions, use return instead of continue.
    
    Change-Id: I5ce95b01359c5cfbb1612f2f48b80bfeea66c96c

Diff:
---
 gdb/gdb_mbuild.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
index 0d4c28e87b1..6a502369070 100755
--- a/gdb/gdb_mbuild.sh
+++ b/gdb/gdb_mbuild.sh
@@ -171,7 +171,7 @@ fail ()
 	if test "${keepgoing}" != ""
 	then
 	    #exit 1
-	    continue
+	    return 1
 	else
 	    kill $$
 	    exit 1


                 reply	other threads:[~2022-07-28 14:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728143116.C8C67385AE5A@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).