public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.threads/killed-outside.exp on aarch64
Date: Fri, 29 Jul 2022 06:49:48 +0000 (GMT)	[thread overview]
Message-ID: <20220729064948.E4727385840A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b245c595aaa59812f8f3a0e8b70ea5f52e045627

commit b245c595aaa59812f8f3a0e8b70ea5f52e045627
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Jul 29 08:49:45 2022 +0200

    [gdb/testsuite] Fix gdb.threads/killed-outside.exp on aarch64
    
    On aarch64 (and likewise on arm), I run into:
    ...
    (gdb) PASS: gdb.threads/killed-outside.exp: get pid of inferior
    Executing on target: kill -9 11516    (timeout = 300)
    builtin_spawn -ignore SIGHUP kill -9 11516^M
    continue^M
    Continuing.^M
    Unable to fetch general registers: No such process.^M
    (gdb) [Thread 0xfffff7d511e0 (LWP 11518) exited]^M
    ^M
    Program terminated with signal SIGKILL, Killed.^M
    The program no longer exists.^M
    FAIL: gdb.threads/killed-outside.exp: prompt after first continue (timeout)
    ...
    due to a mismatch between the actual "No such process" line and the expected
    one:
    ...
    set no_such_process_msg "Couldn't get registers: No such process\."
    ...
    
    Fix this by updating the regexp.
    
    Tested on aarch64-linux, and x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.threads/killed-outside.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.threads/killed-outside.exp b/gdb/testsuite/gdb.threads/killed-outside.exp
index 3d4543e088c..7fa6b26c685 100644
--- a/gdb/testsuite/gdb.threads/killed-outside.exp
+++ b/gdb/testsuite/gdb.threads/killed-outside.exp
@@ -37,7 +37,8 @@ remote_exec target "kill -9 ${testpid}"
 # Give it some time to die.
 sleep 2
 
-set no_such_process_msg "Couldn't get registers: No such process\."
+set regs_msg "(Couldn't get registers|Unable to fetch general registers)"
+set no_such_process_msg "$regs_msg: No such process\."
 set killed_msg "Program terminated with signal SIGKILL, Killed\."
 set no_longer_exists_msg "The program no longer exists\."
 set not_being_run_msg "The program is not being run\."


                 reply	other threads:[~2022-07-29  6:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220729064948.E4727385840A@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).