public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix gdb.ada/convvar_comp.exp with broken debug info
@ 2022-07-29 14:12 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-07-29 14:12 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5ec878132bb39fb43e081dcf53e42aca202b24d9

commit 5ec878132bb39fb43e081dcf53e42aca202b24d9
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Jul 29 16:12:55 2022 +0200

    [gdb/testsuite] Fix gdb.ada/convvar_comp.exp with broken debug info
    
    On aarch64-linux I run into this failure with gcc 7.5.0:
    ...
    (gdb) print $item.started^M
    $1 = (-5312, 65535, 4202476)^M
    (gdb) FAIL: gdb.ada/convvar_comp.exp: print $item.started
    ...
    
    The test-case expects (0, 0, 0), but we're getting another value due to
    incorrect location information.
    
    Work around this by:
    - first printing the value, and then
    - verifying that the convenience variable matches the printed value.
    
    I've verified that the test-case still checks what it should by disabling
    the fix from commit cc0e770c0d0 ("memory error printing component of record
    from convenience variable") and observing the test-case fail.
    
    Tested on x86_64-linux and aarch64-linux.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29420

Diff:
---
 gdb/testsuite/gdb.ada/convvar_comp.exp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.ada/convvar_comp.exp b/gdb/testsuite/gdb.ada/convvar_comp.exp
index ebc2659aeaa..1923bd785c7 100644
--- a/gdb/testsuite/gdb.ada/convvar_comp.exp
+++ b/gdb/testsuite/gdb.ada/convvar_comp.exp
@@ -30,7 +30,15 @@ if ![runto "break_me" ] then {
   return
 }
 
+set val ""
+gdb_test_multiple "print item.started" "" {
+    -re -wrap " = \\((.*)\\)" {
+	set val $expect_out(1,string)
+	pass $gdb_test_name
+    }
+}
+
 gdb_test_no_output "set variable \$item := item"
 
 gdb_test "print \$item.started" \
-         " = \\(0, 0, 0\\)"
+    " = \\($val\\)"


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-29 14:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 14:12 [binutils-gdb] [gdb/testsuite] Fix gdb.ada/convvar_comp.exp with broken debug info Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).