From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7872) id 9EAD33858CDB; Wed, 3 Aug 2022 12:29:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EAD33858CDB Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Enze Li To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/amd64: clean up unused variable X-Act-Checkin: binutils-gdb X-Git-Author: Enze Li X-Git-Refname: refs/heads/master X-Git-Oldrev: f74a5e6f2ed5180ce28d6478a6d7a7a1982c5d43 X-Git-Newrev: 8b8da1a9f31941fa167c9f2bd2a80cdd1dccb452 Message-Id: <20220803122922.9EAD33858CDB@sourceware.org> Date: Wed, 3 Aug 2022 12:29:22 +0000 (GMT) X-BeenThere: gdb-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 12:29:22 -0000 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8b8da1a9f319= 41fa167c9f2bd2a80cdd1dccb452 commit 8b8da1a9f31941fa167c9f2bd2a80cdd1dccb452 Author: Enze Li Date: Tue Aug 2 06:11:50 2022 +0800 gdb/amd64: clean up unused variable =20 When building with clang 15, I got this, =20 CXX amd64-tdep.o amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-= Wunused-but-set-variable] gdb_byte *insn =3D insn_details->raw_insn + modrm_offset; ^ 1 error generated. =20 The function that uses this variable has been removed in this commit, =20 commit 870f88f7551b0f2d6aaaa36fb684b5ff8f468107 Date: Mon Apr 18 13:16:27 2016 -0400 =20 remove trivialy unused variables =20 Fix this by removing unused variable. =20 Tested by rebuilding on x86_64-linux with clang 15 and gcc 12. Diff: --- gdb/amd64-tdep.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 0563b32a54b..d89e06d27cb 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -1407,15 +1407,11 @@ fixup_riprel (struct gdbarch *gdbarch, { const struct amd64_insn *insn_details =3D &dsc->insn_details; int modrm_offset =3D insn_details->modrm_offset; - gdb_byte *insn =3D insn_details->raw_insn + modrm_offset; CORE_ADDR rip_base; int insn_length; int arch_tmp_regno, tmp_regno; ULONGEST orig_value; =20 - /* %rip+disp32 addressing mode, displacement follows ModRM byte. */ - ++insn; - /* Compute the rip-relative address. */ insn_length =3D gdb_buffered_insn_length (gdbarch, dsc->insn_buf.data (), dsc->insn_buf.size (), from);