public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/csky fix build error in ubuntu20_04
@ 2022-08-09  2:19 Jiangshuai Li
  0 siblings, 0 replies; only message in thread
From: Jiangshuai Li @ 2022-08-09  2:19 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=65c9841b6fee984714509acef6e52366363072b6

commit 65c9841b6fee984714509acef6e52366363072b6
Author: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>
Date:   Tue Aug 9 10:13:57 2022 +0800

    gdb/csky fix build error in ubuntu20_04
    
    build error in: https://builder.sourceware.org/buildbot/#/builders/170/builds/246
    ...
    ../../binutils-gdb/gdb/csky-linux-tdep.c: In function ‘void
    csky_supply_fregset(const regset*, regcache*, int, const void*, size_t)’:
    ../../binutils-gdb/gdb/csky-linux-tdep.c:194:18: error: format ‘%ld’
    expects argument of type ‘long int’, but argument 2 has type ‘size_t’
    {aka ‘unsigned int’} [-Werror=format=]
       194 |       warning (_("Unknow size %ld of section .reg2, can not get
    value"
           |
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       195 |    " of float registers."), len);
    ...
    
    Fix it via using %s vs pulongest suggested by Tom.

Diff:
---
 gdb/csky-linux-tdep.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/csky-linux-tdep.c b/gdb/csky-linux-tdep.c
index 106f629b8b0..ae5d2bba33c 100644
--- a/gdb/csky-linux-tdep.c
+++ b/gdb/csky-linux-tdep.c
@@ -191,8 +191,8 @@ csky_supply_fregset (const struct regset *regset,
     }
   else
     {
-      warning (_("Unknow size %ld of section .reg2, can not get value"
-		 " of float registers."), len);
+      warning (_("Unknow size %s of section .reg2, can not get value"
+		 " of float registers."), pulongest (len));
     }
 }
 
@@ -272,8 +272,8 @@ csky_collect_fregset (const struct regset *regset,
     }
   else
     {
-      warning (_("Unknow size %ld of section .reg2, will not set value"
-		 " of float registers."), len);
+      warning (_("Unknow size %s of section .reg2, will not set value"
+		 " of float registers."), pulongest (len));
     }
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-09  2:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09  2:19 [binutils-gdb] gdb/csky fix build error in ubuntu20_04 Jiangshuai Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).