public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/riscv: use register name enum values in riscv-linux-nat.c Date: Tue, 9 Aug 2022 11:13:26 +0000 (GMT) [thread overview] Message-ID: <20220809111326.377B03857400@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8cf61a33bba791c38e1b2f6cf2f276d052a1f17e commit 8cf61a33bba791c38e1b2f6cf2f276d052a1f17e Author: Andrew Burgess <aburgess@redhat.com> Date: Tue Aug 9 12:10:03 2022 +0100 gdb/riscv: use register name enum values in riscv-linux-nat.c There were a few places where we were using integer values rather than the RISCV_*_REGNUM constants defined in riscv-tdep.h. This commit replaces 0 with RISCV_ZERO_REGNUM and 32 with RISCV_PC_REGNUM in a few places. There should be no user visible changes after this commit. Diff: --- gdb/riscv-linux-nat.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/riscv-linux-nat.c b/gdb/riscv-linux-nat.c index 70634941483..5fbb0ca5add 100644 --- a/gdb/riscv-linux-nat.c +++ b/gdb/riscv-linux-nat.c @@ -66,17 +66,17 @@ supply_gregset_regnum (struct regcache *regcache, const prgregset_t *gregs, regcache->raw_supply (i, regp + i); /* GDB stores PC in reg 32. Linux kernel stores it in reg 0. */ - regcache->raw_supply (32, regp + 0); + regcache->raw_supply (RISCV_PC_REGNUM, regp + 0); /* Fill the inaccessible zero register with zero. */ - regcache->raw_supply_zeroed (0); + regcache->raw_supply_zeroed (RISCV_ZERO_REGNUM); } else if (regnum == RISCV_ZERO_REGNUM) - regcache->raw_supply_zeroed (0); + regcache->raw_supply_zeroed (RISCV_ZERO_REGNUM); else if (regnum > RISCV_ZERO_REGNUM && regnum < RISCV_PC_REGNUM) regcache->raw_supply (regnum, regp + regnum); else if (regnum == RISCV_PC_REGNUM) - regcache->raw_supply (32, regp + 0); + regcache->raw_supply (RISCV_PC_REGNUM, regp + 0); } /* Copy all general purpose registers from regset GREGS into REGCACHE. */ @@ -147,7 +147,7 @@ fill_gregset (const struct regcache *regcache, prgregset_t *gregs, int regnum) for (int i = RISCV_ZERO_REGNUM + 1; i < RISCV_PC_REGNUM; i++) regcache->raw_collect (i, regp + i); - regcache->raw_collect (32, regp + 0); + regcache->raw_collect (RISCV_PC_REGNUM, regp + 0); } else if (regnum == RISCV_ZERO_REGNUM) /* Nothing to do here. */ @@ -155,7 +155,7 @@ fill_gregset (const struct regcache *regcache, prgregset_t *gregs, int regnum) else if (regnum > RISCV_ZERO_REGNUM && regnum < RISCV_PC_REGNUM) regcache->raw_collect (regnum, regp + regnum); else if (regnum == RISCV_PC_REGNUM) - regcache->raw_collect (32, regp + 0); + regcache->raw_collect (RISCV_PC_REGNUM, regp + 0); } /* Copy floating point register REGNUM (or all fp regs if REGNUM == -1)
reply other threads:[~2022-08-09 11:13 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220809111326.377B03857400@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).