public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: change bpstat_print's kind parameter to target_waitkind
Date: Fri, 26 Aug 2022 14:32:38 +0000 (GMT)	[thread overview]
Message-ID: <20220826143238.59F403858403@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=403c71fdace8e0f16807470ec1c3dc505bcb78d4

commit 403c71fdace8e0f16807470ec1c3dc505bcb78d4
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Thu Aug 25 15:38:44 2022 -0400

    gdb: change bpstat_print's kind parameter to target_waitkind
    
    Change from int to target_waitkind,  which is really what is is.  While
    at it, remove some outdated doc.  The return value is described by a
    relatively self-describing enum, not a numerical value like the doc
    says.
    
    Change-Id: Id899c853a857c7891c45e5b1639024067d5b59cd

Diff:
---
 gdb/breakpoint.c | 2 +-
 gdb/breakpoint.h | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 2fe74ea0d3a..8f0b19f8518 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -4803,7 +4803,7 @@ print_solib_event (bool is_catchpoint)
    further info to be printed.  */
 
 enum print_stop_action
-bpstat_print (bpstat *bs, int kind)
+bpstat_print (bpstat *bs, target_waitkind kind)
 {
   enum print_stop_action val;
 
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index aaf7549b660..93f30c9c13d 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -35,6 +35,7 @@
 #include "gdbsupport/refcounted-object.h"
 #include "gdbsupport/safe-iterator.h"
 #include "cli/cli-script.h"
+#include "target/waitstatus.h"
 
 struct block;
 struct gdbpy_breakpoint_object;
@@ -1226,10 +1227,8 @@ extern bool bpstat_causes_stop (bpstat *);
    just to things like whether watchpoints are set.  */
 extern bool bpstat_should_step ();
 
-/* Print a message indicating what happened.  Returns nonzero to
-   say that only the source line should be printed after this (zero
-   return means print the frame as well as the source line).  */
-extern enum print_stop_action bpstat_print (bpstat *, int);
+/* Print a message indicating what happened.  */
+extern enum print_stop_action bpstat_print (bpstat *bs, target_waitkind kind);
 
 /* Put in *NUM the breakpoint number of the first breakpoint we are
    stopped at.  *BSP upon return is a bpstat which points to the

                 reply	other threads:[~2022-08-26 14:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220826143238.59F403858403@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).