public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/tdep] Declare score-*-* target obsolete
Date: Tue, 30 Aug 2022 08:22:35 +0000 (GMT)	[thread overview]
Message-ID: <20220830082235.2ED403857C72@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=28b5cde22b1a858b8c05da0f03ba37c670798298

commit 28b5cde22b1a858b8c05da0f03ba37c670798298
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Aug 30 10:22:28 2022 +0200

    [gdb/tdep] Declare score-*-* target obsolete
    
    I tried out the script gdb/gdb_mbuild.sh, and ran into:
    ...
    score-elf ...
    ... configure --target=score-elf
    ... make score-elf
    ... run score-elf
    score-elf: gdb dumped core
    Terminated
    ...
    
    Gdb runs into this internal error in initialize_current_architecture:
    ...
      if (! gdbarch_update_p (info))
        internal_error (__FILE__, __LINE__,
                        _("initialize_current_architecture: Selection of "
                          "initial architecture failed"));
    ...
    
    The call to gdbarch_update_p fails because commit 575b4c298a6 ("gdb: Remove
    support for S+core") removed support for the architecture.
    
    Fix this by adding score-*-* to the list of obsolete targets in
    gdb/configure.tgt, such that we're no longer able to build the configuration:
    ...
    *** Configuration score-unknown-elf is obsolete.
    *** Support has been REMOVED.
    make: *** [Makefile:12806: configure-gdb] Error 1
    ...
    
    Also remove the related line from the "Target Instruction Set Architectures"
    list in gdb/MAINTAINERS, such that gdb/gdb_mbuild.sh no longer tries to build
    it.

Diff:
---
 gdb/MAINTAINERS   | 1 -
 gdb/configure.tgt | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
index ef507e57590..00b9a5ce5e8 100644
--- a/gdb/MAINTAINERS
+++ b/gdb/MAINTAINERS
@@ -325,7 +325,6 @@ the native maintainer when resolving ABI issues.
 	s390		--target=s390-linux-gnu ,-Werror
 			Andreas Arnez		arnez@linux.ibm.com
 
-	score		--target=score-elf
 	sh		--target=sh-elf ,-Werror
 
 	sparc		--target=sparcv9-solaris2.11 ,-Werror
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index 0705ccf32b8..e84e222ba0d 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -26,6 +26,7 @@ case $targ in
  m68*-*-os68k* | \
  mips*-*-pe | \
  rs6000-*-lynxos* | \
+ score-*-* | \
  sh*-*-pe | \
  hppa*-*-hpux* | \
  ia64-*-hpux* | \

                 reply	other threads:[~2022-08-30  8:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220830082235.2ED403857C72@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).