public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: Add tdesc_found_register function to tdesc API Date: Wed, 31 Aug 2022 15:33:05 +0000 (GMT) [thread overview] Message-ID: <20220831153305.A0774385840A@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b49d7aa74466fb73529ebf0e6c907c2142505610 commit b49d7aa74466fb73529ebf0e6c907c2142505610 Author: Andrew Burgess <aburgess@redhat.com> Date: Thu Aug 11 12:43:08 2022 +0100 gdb: Add tdesc_found_register function to tdesc API This commit adds a new function to the target description API within GDB. This new function is not used in this commit, but will be used in the next commit, I'm splitting it out into a separate patch for easier review. What I want to do in the next commit is check to see if a target description supplied a particular register, however, the register in question could appear in one of two possible features. The new function allows me to ask the tdesc_arch_data whether a register was found and assigned a particular GDB register number once all of the features have been checked. I think this is a much simpler solution than adding code such that, while checking each feature, I spot if the register I'm processing is the one I care about. No tests here as the new code is not used, but this code will be exercised in the next commit. Diff: --- gdb/target-descriptions.c | 11 +++++++++++ gdb/target-descriptions.h | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index d5d795875c2..044b171ecd2 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -849,6 +849,17 @@ tdesc_numbered_register_choices (const struct tdesc_feature *feature, return 0; } +/* See target-descriptions.h. */ + +bool +tdesc_found_register (struct tdesc_arch_data *data, int regno) +{ + gdb_assert (regno >= 0); + + return (regno < data->arch_regs.size () + && data->arch_regs[regno].reg != nullptr); +} + /* Search FEATURE for a register named NAME, and return its size in bits. The register must exist. */ diff --git a/gdb/target-descriptions.h b/gdb/target-descriptions.h index 3b90dedcd80..3ab0ae2542d 100644 --- a/gdb/target-descriptions.h +++ b/gdb/target-descriptions.h @@ -170,6 +170,10 @@ int tdesc_numbered_register_choices (const struct tdesc_feature *feature, struct tdesc_arch_data *data, int regno, const char *const names[]); +/* Return true if DATA contains an entry for REGNO, a GDB register + number. */ + +extern bool tdesc_found_register (struct tdesc_arch_data *data, int regno); /* Accessors for target descriptions. */
reply other threads:[~2022-08-31 15:33 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220831153305.A0774385840A@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).