public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Let ui::input_fd be -1 Date: Wed, 31 Aug 2022 17:00:02 +0000 (GMT) [thread overview] Message-ID: <20220831170002.44EF43858D39@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=51cacdb50fd2ac2240172a63140e56c0adb41742 commit 51cacdb50fd2ac2240172a63140e56c0adb41742 Author: Tom Tromey <tromey@adacore.com> Date: Tue Aug 30 11:30:13 2022 -0600 Let ui::input_fd be -1 This changes gdb so that, if ui::input_fd is set to -1, then it will not be registered with the event loop. This is useful for the DAP support code I wrote, but as it turns out to also be useful to Insight, it seems best to check it in separately. Diff: --- gdb/event-top.c | 8 +++++--- gdb/top.h | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index 02b3786320f..4547d614522 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -533,8 +533,9 @@ stdin_event_handler (int error, gdb_client_data client_data) void ui::register_file_handler () { - add_file_handler (input_fd, stdin_event_handler, this, - string_printf ("ui-%d", num), true); + if (input_fd != -1) + add_file_handler (input_fd, stdin_event_handler, this, + string_printf ("ui-%d", num), true); } /* See top.h. */ @@ -542,7 +543,8 @@ ui::register_file_handler () void ui::unregister_file_handler () { - delete_file_handler (input_fd); + if (input_fd != -1) + delete_file_handler (input_fd); } /* Re-enable stdin after the end of an execution command in diff --git a/gdb/top.h b/gdb/top.h index 5c1db84b2ce..9ea07262c39 100644 --- a/gdb/top.h +++ b/gdb/top.h @@ -118,7 +118,8 @@ struct ui FILE *errstream; /* The file descriptor for the input stream, so that we can register - it with the event loop. */ + it with the event loop. This can be set to -1 to prevent this + registration. */ int input_fd; /* Whether ISATTY returns true on input_fd. Cached here because
reply other threads:[~2022-08-31 17:00 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220831170002.44EF43858D39@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).