public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Remove some dead code
Date: Wed, 31 Aug 2022 17:14:09 +0000 (GMT)	[thread overview]
Message-ID: <20220831171409.D0446385277B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10d6fc874c0201bd28c57525fc9465f2bcd680ec

commit 10d6fc874c0201bd28c57525fc9465f2bcd680ec
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Aug 10 14:01:16 2022 -0600

    Remove some dead code
    
    This patch removes some dead code and an old FIXME.  These no longer
    seem useful, even for documentation purposes.

Diff:
---
 gdb/event-top.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/gdb/event-top.c b/gdb/event-top.c
index 4547d614522..a06221b1b80 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -1380,19 +1380,6 @@ gdb_disable_readline (void)
 {
   struct ui *ui = current_ui;
 
-  /* FIXME - It is too heavyweight to delete and remake these every
-     time you run an interpreter that needs readline.  It is probably
-     better to have the interpreters cache these, which in turn means
-     that this needs to be moved into interpreter specific code.  */
-
-#if 0
-  ui_file_delete (gdb_stdout);
-  ui_file_delete (gdb_stderr);
-  gdb_stdlog = NULL;
-  gdb_stdtarg = NULL;
-  gdb_stdtargerr = NULL;
-#endif
-
   if (ui->command_editing)
     gdb_rl_callback_handler_remove ();
   ui->unregister_file_handler ();

             reply	other threads:[~2022-08-31 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 17:14 Tom Tromey [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-04-29 14:12 Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831171409.D0446385277B@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).