public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove some dead code
@ 2022-08-31 17:14 Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-08-31 17:14 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10d6fc874c0201bd28c57525fc9465f2bcd680ec

commit 10d6fc874c0201bd28c57525fc9465f2bcd680ec
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Aug 10 14:01:16 2022 -0600

    Remove some dead code
    
    This patch removes some dead code and an old FIXME.  These no longer
    seem useful, even for documentation purposes.

Diff:
---
 gdb/event-top.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/gdb/event-top.c b/gdb/event-top.c
index 4547d614522..a06221b1b80 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -1380,19 +1380,6 @@ gdb_disable_readline (void)
 {
   struct ui *ui = current_ui;
 
-  /* FIXME - It is too heavyweight to delete and remake these every
-     time you run an interpreter that needs readline.  It is probably
-     better to have the interpreters cache these, which in turn means
-     that this needs to be moved into interpreter specific code.  */
-
-#if 0
-  ui_file_delete (gdb_stdout);
-  ui_file_delete (gdb_stderr);
-  gdb_stdlog = NULL;
-  gdb_stdtarg = NULL;
-  gdb_stdtargerr = NULL;
-#endif
-
   if (ui->command_editing)
     gdb_rl_callback_handler_remove ();
   ui->unregister_file_handler ();

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [binutils-gdb] Remove some dead code
@ 2020-04-29 14:12 Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2020-04-29 14:12 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fc49bc72378b4402ca60baa5ff65f1392c92c279

commit fc49bc72378b4402ca60baa5ff65f1392c92c279
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Apr 29 08:10:28 2020 -0600

    Remove some dead code
    
    print_block_frame_labels has been commented out since 2010.
    I don't think we need it; this patch removes it.
    
    2020-04-29  Tom Tromey  <tom@tromey.com>
    
            * stack.c (print_block_frame_labels): Remove.

Diff:
---
 gdb/ChangeLog |  4 ++++
 gdb/stack.c   | 50 --------------------------------------------------
 2 files changed, 4 insertions(+), 50 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9e1ce39c9e2..987b997bab7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-04-29  Tom Tromey  <tom@tromey.com>
+
+	* stack.c (print_block_frame_labels): Remove.
+
 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 
 	PR gdb/17320
diff --git a/gdb/stack.c b/gdb/stack.c
index af35d796d70..7f541a6a010 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -2257,56 +2257,6 @@ iterate_over_block_locals (const struct block *b,
     }
 }
 
-
-/* Same, but print labels.  */
-
-#if 0
-/* Commented out, as the code using this function has also been
-   commented out.  FIXME:brobecker/2009-01-13: Find out why the code
-   was commented out in the first place.  The discussion introducing
-   this change (2007-12-04: Support lexical blocks and function bodies
-   that occupy non-contiguous address ranges) did not explain why
-   this change was made.  */
-static int
-print_block_frame_labels (struct gdbarch *gdbarch, struct block *b,
-			  int *have_default, struct ui_file *stream)
-{
-  struct block_iterator iter;
-  struct symbol *sym;
-  int values_printed = 0;
-
-  ALL_BLOCK_SYMBOLS (b, iter, sym)
-    {
-      if (strcmp (sym->linkage_name (), "default") == 0)
-	{
-	  if (*have_default)
-	    continue;
-	  *have_default = 1;
-	}
-      if (SYMBOL_CLASS (sym) == LOC_LABEL)
-	{
-	  struct symtab_and_line sal;
-	  struct value_print_options opts;
-
-	  sal = find_pc_line (SYMBOL_VALUE_ADDRESS (sym), 0);
-	  values_printed = 1;
-	  fputs_filtered (sym->print_name (), stream);
-	  get_user_print_options (&opts);
-	  if (opts.addressprint)
-	    {
-	      fprintf_filtered (stream, " ");
-	      fputs_filtered (paddress (gdbarch, SYMBOL_VALUE_ADDRESS (sym)),
-			      stream);
-	    }
-	  fprintf_filtered (stream, " in file %s, line %d\n",
-			    sal.symtab->filename, sal.line);
-	}
-    }
-
-  return values_printed;
-}
-#endif
-
 /* Iterate over all the local variables in block B, including all its
    superblocks, stopping when the top-level block is reached.  */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-31 17:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 17:14 [binutils-gdb] Remove some dead code Tom Tromey
  -- strict thread matches above, loose matches on Subject: below --
2020-04-29 14:12 Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).