public inbox for firstname.lastname@example.org help / color / mirror / Atom feed
From: Tom Tromey <email@example.com> To: firstname.lastname@example.org Subject: [binutils-gdb] Free ui::line_buffer Date: Wed, 31 Aug 2022 17:14:14 +0000 (GMT) [thread overview] Message-ID: <20220831171414.E093A38582B4@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=55a6603404099c0b61a5e4613712d3935c2e2bb6 commit 55a6603404099c0b61a5e4613712d3935c2e2bb6 Author: Tom Tromey <email@example.com> Date: Thu Aug 11 09:23:47 2022 -0600 Free ui::line_buffer A ui initializes its line_buffer, but never calls buffer_free on it. This patch fixes the oversight. I found this by inspection. Diff: --- gdb/top.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/top.c b/gdb/top.c index 07e491440e4..18a447e701b 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -352,6 +352,8 @@ ui::~ui () delete m_gdb_stdin; delete m_gdb_stdout; delete m_gdb_stderr; + + buffer_free (&line_buffer); } /* Open file named NAME for read/write, making sure not to make it the
reply other threads:[~2022-08-31 17:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220831171414.E093A38582B4@sourceware.org \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).